touch-packages team mailing list archive

[Martin Pitt <martin.pitt@xxxxxxxxxx>]

Dann,

I think it's more consistent to use the same rule structure as in
ProLiant-m800-power-button.patch, i. e. "cat" and RESULT=. If you want
to use grep, then please use "grep -q". I'm also ok with using grep in
both rules, but we should just use one form.

Also, please merge this into the previous patch, and rename to ProLiant-
power-button.patch; there might be more platforms, and we don't want
dozens of these very closely related micro-patches. That will make patch
review/changing, easier and reduce patch interdependencies.

Otherwise this LGTM. Please don't upload the utopic one, I'll apply your
final patch for trusty to the Debian/Ubuntu packaging git and then
upload with some other changes soon. (I suppose the pressing part is
trusty, not utopic?)

Thanks!

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to systemd in Ubuntu.
https://bugs.launchpad.net/bugs/1354306

Title:
  gpio shutdown trigger for ProLiant m400 cartridges

Status in systemd:
  Confirmed
Status in “systemd” package in Ubuntu:
  Triaged
Status in “systemd” source package in Trusty:
  Triaged
Status in “systemd” source package in Utopic:
  Triaged

Bug description:
  Similar to the m800 case in LP: #1347776, udev/systemd also needs to
  know how to trigger a graceful shutdown on ProLiant m400 cartridges.

  [Impact]
  Without this change, the power down button will not initiate an OS shutdown on this platform.
  [Test Case]
  Push button. Watch poweroff occur.
  [Regression Potential]
  The new rule is pretty tightly bound to the m400 system - so the risk of this rule matching and impacting behavior on a different platform is minimal. This will presumably cause new code to run and read /proc/device-tree/model on other platforms - but this is already done for the m800 system in both utopic and trusty.

To manage notifications about this bug go to:
https://bugs.launchpad.net/systemd/+bug/1354306/+subscriptions