← Back to team overview

touch-packages team mailing list archive

[Bug 1343198] Re: [performance] Mir spends 12%+ CPU time in get_hooked_symbol (libhybris-common) comparing strings

 

This bug was fixed in the package libhybris -
0.1.0+git20131207+e452e83-0ubuntu26

---------------
libhybris (0.1.0+git20131207+e452e83-0ubuntu26) utopic; urgency=medium

  [ Yu-Cheng Chou <ianchou821@xxxxxxxxx> ]
  * debian/control: fix typo in description (LP: #1259444)

  [ Daniel van Vugt ]
  * hooks: converting linear search into a binary search
    (LP: #1343198)
 -- Ricardo Salveti de Araujo <ricardo.salveti@xxxxxxxxxxxxx>   Thu, 14 Aug 2014 17:45:44 -0300

** Changed in: libhybris (Ubuntu)
       Status: Triaged => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to libhybris in Ubuntu.
https://bugs.launchpad.net/bugs/1343198

Title:
  [performance] Mir spends 12%+ CPU time in get_hooked_symbol
  (libhybris-common) comparing strings

Status in Mir:
  Invalid
Status in “libhybris” package in Ubuntu:
  Fix Released

Bug description:
  On the N4, Mir spends 12%+ CPU time in get_hooked_symbol (libhybris-
  common). Actually callgrind can't decide; it's somewhere between 12%
  and 46000% ;)

  So it's big. Looking at the hybris code, there's a rather large
  bottleneck that's obvious: get_hooked_symbol does a linear search
  (many times) of a large list of strings using strcmp alone. That's why
  22132 calls to get_hooked_symbol are yielding over 5 million calls to
  strcmp.

  Upstream hybris appears to have been modified to use a cache/hashing
  instead of the ugly linear search we have.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mir/+bug/1343198/+subscriptions


References