touch-packages team mailing list archive

[Chris Coulson <chris.coulson@xxxxxxxxxxxxx>]

** Changed in: oxide
   Importance: High => Medium

** Changed in: oxide
     Assignee: (unassigned) => Chris Coulson (chrisccoulson)

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to webbrowser-app in Ubuntu.
https://bugs.launchpad.net/bugs/1458963

Title:
  Favicons are saved to disk in private browsing mode

Status in Oxide:
  Triaged
Status in webbrowser-app:
  Fix Released
Status in webbrowser-app package in Ubuntu:
  Fix Released

Bug description:
  Currently, Oxide provides a http URL for the favicon via WebView.icon
  and the browser uses this URL to download the image via Qt's network
  stack. As well as displaying this in the addressbar, it also writes it
  to disk.

  There's a couple of problems here:

  1) The favicon is written to disk even in private browsing mode.
  2) I'm not too sure about this, but downloading using Qt's network stack potentially leaves a cache footprint. In any case, we don't audit its suitability for use with private browsing.

  The first part will need to be fixed in the browser.

  For the second part, I think that Oxide should do the actual network
  transaction to fetch the favicon. We can provide an implementation of
  QQmlImageProvider and make WebView.icon a image: URL. The browser
  should still be able to use this URL to access and write the icons to
  disk (I assume this is for displaying history), but it would do this
  by requesting the QImage from Oxide's image provider, using
  QQmlEngine::imageProvider() rather than doing the network transaction
  itself.

To manage notifications about this bug go to:
https://bugs.launchpad.net/oxide/+bug/1458963/+subscriptions