← Back to team overview

touch-packages team mailing list archive

[Bug 1498539] Re: FaviconFetcherTests random failures in silo builds

 

The bug fix https://codereview.qt-project.org/#/c/120738 links to a bug that indicates QNAM erronously closing queued multiple requests with 'Unknown error' and a warning before that "QIODevice:::write device not open" which matches what the test mentions. And the fix itself states "This patch changes the QNAM socket slot connections to be DirectConnection.
We don't close the socket anymore in slots where it is anyway in a closed state afterwards. This prevents event/stack recursions.". Could the type change to DirectConnection cause this change of behavior?

I've rebuilt Scopes packages, unity8, and download manager to have unit
test results in addition to autopilot tests that I did earlier, and it
still seems to be that the only flakiness is this webbrowser-app unit
test, and on x86 only: https://launchpad.net/~canonical-
qt5-edgers/+archive/qt5-beta1/+packages As x86 is faster, maybe there's
something timing related.

I've asked pstolowski to look whether he can see a delta with/without
the patch. He mentioned there have been some 'device is open' in bug
reports in the past, which is one of the symptoms being fixed by the bug
fix.

It's also useful to know that this bug fix itself is a bug fix to an
earlier fix https://codereview.qt-project.org/#/c/110150/ which upstream
urged everyone to ship, and we're currently doing that (in OTA-6). So if
we're not seeing worrying regressions, it sounds like a worthwhile bug
fix that may help random network failures in QNAM using components.

To switch between with/without patch, the revert of this latter patch is
in silo 054. One can use the pinning
(https://wiki.ubuntu.com/LandingTeam/SiloTestingGuidelines#Install_silos_with_overlay_PPA_enabled),
enabling/disabling the file and  "apt upgrade" will allow to both
quickly "upgrade to the revert" or "downgrade to the fix that was
landed".

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to qtbase-opensource-src in
Ubuntu.
https://bugs.launchpad.net/bugs/1498539

Title:
  FaviconFetcherTests random failures in silo builds

Status in qtbase-opensource-src package in Ubuntu:
  New
Status in webbrowser-app package in Ubuntu:
  Triaged

Bug description:
  Since yesterday (2015-09-21), FaviconFetcherTests started failing at
  random in silo builds (not failing all the time, but in about 75% of
  the builds, on amd64 and i386, not on armhf).

  Since it has been happening in several silos, it’s very unlikely that
  it’s a change in webbrowser-app itself that triggered the failure.
  It’s more likely a change somewhere else in the stack that triggered a
  bug that was already there.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/qtbase-opensource-src/+bug/1498539/+subscriptions


References