touch-packages team mailing list archive

[Oliver Grawert <ogra@xxxxxxxxxx>]

with this fix my App does not recieve any fullscreen events from an
embedded WebView anymore with the following code:

        Connections {
            target: webview
            onFullscreenChanged: {
                nav.visible = !webview.fullscreen
                if (webview.fullscreen == true) {
                    window.visibility = 5
                } else {
                    window.visibility = 4
                }
            }
        }

when i hack /usr/lib/arm-linux-
gnueabihf/qt5/qml/Ubuntu/Components/Extras/Browser/UbuntuWebView02.qml
on the phone to revert the change all is fine and embedded videos
properly emit the onFullscreenChanged to the webview. i assume i need to
do any code changes on my side to use an embedded WebView this way now.
are these changes somewhere documented ?

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to webbrowser-app in Ubuntu.
https://bugs.launchpad.net/bugs/1464249

Title:
  Ubuntu WebView should not silently honour fullscreen requests

Status in webbrowser-app package in Ubuntu:
  Fix Released

Bug description:
  The current implementation¹ does this:

      onFullscreenRequested: _webview.fullscreen = fullscreen

  
  ¹ http://bazaar.launchpad.net/~phablet-team/webbrowser-app/trunk/view/head:/src/Ubuntu/Web/UbuntuWebView02.qml#L270

  
  This default behaviour is not necessarily desirable for most embedders, who might want to intercept the request and cancel it.
  Changing the default behaviour doesn’t require an API change, so it should be safe to do at any point in time (and the sooner the better).

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/webbrowser-app/+bug/1464249/+subscriptions