← Back to team overview

touch-packages team mailing list archive

[Bug 1394511] Re: It should be possible to make Dialog respect its parent

 

** Changed in: canonical-devices-system-image
       Status: New => Fix Released

** No longer affects: ubuntu-ui-toolkit (Ubuntu Vivid)

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to ubuntu-ui-toolkit in
Ubuntu.
https://bugs.launchpad.net/bugs/1394511

Title:
  It should be possible to make Dialog respect its parent

Status in Canonical System Image:
  Fix Released
Status in ubuntu-ui-toolkit package in Ubuntu:
  Fix Released

Bug description:
  In the future unity8 will rotate instead of having apps rotating
  themselves. So that launcher, edge gestures, panel and application UI
  all have the same orientation and rotate together nicely. This
  includes the dialogs shown by unity8, such as the power dialog that
  pops up when you long-press the power button.

  This is unity8's hierarchy:

  // the root item
  OrientedShell {

      // the actual Shell UI, which gets rotated
      Shell {
          rotation: someAngle

          Loader {
              Dialog {
              }
          }
      }
  }

  So we need the Dialogs to keep their parents so that they carry on the
  transformations applied to Shell, instead of being a sibling of it.
  This should be simple to accomplish as Dialog is an Item, and items
  are expected to respect their parents instead of reparenting
  themselves. So I'm just asking Dialog to *do less*.

  Dialog is an Item and thus inherits its public API. Items have a
  parent property that is free for the user to manipulate it. Dialog
  should respect it.

  Otherwise we will have to poke into Dialogs private API to achieve
  that, which is a fragile approach as that can break at any future
  release without warnings. Another bad option would be forking Dialog
  code, copying it over to unity8 code base (as we already do for the
  splash screen feature).

To manage notifications about this bug go to:
https://bugs.launchpad.net/canonical-devices-system-image/+bug/1394511/+subscriptions