← Back to team overview

touch-packages team mailing list archive

[Bug 1480947] Re: Use SortFilterModel for custom models

 

This bug was fixed in the package webbrowser-app -
0.23+16.04.20151204-0ubuntu1

---------------
webbrowser-app (0.23+16.04.20151204-0ubuntu1) xenial; urgency=medium

  [ CI Train Bot ]
  * New rebuild forced.
  * Resync trunk.

  [ Olivier Tilloy ]
  * Fix 3 autopilot test failures on desktop in narrow mode. (LP:
    #1522344)
  * Fix multiple keyboard focus/shortcut issues. (LP: #1522776,
    #1522783, #1522757, #1522767)
  * Replace custom models (HistoryDomainListChronologicalModel,
    HistoryLastVisitDateModel and TopSitesModel) with simple, pure QML
    SortFilterModel instances. Remove entirely HistoryTimeframeModel
    which was not needed any longer. (LP: #1480947)
  * Skip a test that requires HTTPS support in the test suite, which is
    lacking for now.
  * Update translation template.

 -- Olivier Tilloy <olivier.tilloy@xxxxxxxxxxxxx>  Fri, 04 Dec 2015
11:06:50 +0000

** Changed in: webbrowser-app (Ubuntu)
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to webbrowser-app in Ubuntu.
https://bugs.launchpad.net/bugs/1480947

Title:
  Use SortFilterModel for custom models

Status in Canonical System Image:
  Fix Committed
Status in webbrowser-app package in Ubuntu:
  Fix Released

Bug description:
  While browsing the UITK documentation, I stumbled upon
  https://developer.ubuntu.com/api/apps/qml/sdk-15.04/Ubuntu.Components.SortFilterModel/,
  which is essentially QSortFilterProxyModel exposed to QML.

  webbrowser-app has a number of custom models written in C++ that
  inherit QSortFilterProxyModel. Some of them could most likely be
  replaced by a pure QML component with this model from the UITK.

  From a very quick glance, the following models are candidates:
   - HistoryDomainModel
   - BookmarksFolderModel
   - HistoryDomainListChronologicalModel

  This would have the advantage of removing a significant amount of
  custom C++ code, speeding up build time and unit tests run time.

To manage notifications about this bug go to:
https://bugs.launchpad.net/canonical-devices-system-image/+bug/1480947/+subscriptions


References