← Back to team overview

touch-packages team mailing list archive

[Bug 1531038] Re: Cancellation happens too late

 

Thanks for that. Yes, I figured that too. The question is whether, they
way things are at the moment, things are ever deleted. We allow up to 20
async requests via dbus and then queue any additional ones up on the
client side. With the remote server taking 3-10 seconds for each image,
it's easy to pile up a few hundred requests just by scrolling down
quickly.

Now, when we get a cancel(), we actually cancel() the request if it's
one that is still in the queue waiting to be sent. And we don't kick the
queue to start working on another request until an earlier request
completes. The question for me right now is "at what point (if any) does
the listview cancel requests that scroll off the top of the screen while
they are still waiting?"

The behavior I'm seeing when scrolling forward suggests that nothing is
ever cancelled (or that cancellation isn't working for some reason). If
cancellation did work, I wouldn't have to wait for the 200 requests that
I just scrolled past to complete before the current region of the
listview gets its thumbnails.

At this point, it's still investigation. I don't know what exactly is
happening just yet. It's possible that there is still a bug in our
request cancellation.

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to thumbnailer in Ubuntu.
https://bugs.launchpad.net/bugs/1531038

Title:
  Cancellation happens too late

Status in thumbnailer package in Ubuntu:
  New

Bug description:
  I'm still not happy with cancellation. The thumbnailer handles
  cancellation correctly, that is, successfully cancels anything that
  hasn't been sent via dbus yet. But it doesn't work well at the UI
  level. When thumbnailing a large collection of MP3s without artwork
  and scrolling forward quickly, the requests that are scrolling off the
  top of the screen are not physically cancelled, so it takes a long
  time for the thumbnails for the visible section of the list to show
  up. In addition, more often than not, the application times out and
  shows "no artwork" images.

  Ideally, I'd like to see whatever is in the currently visible section
  to get priority.

  Need to investigate what exactly is going on here and whether there
  might be a way to mitigate the issue.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/thumbnailer/+bug/1531038/+subscriptions


References