← Back to team overview

touch-packages team mailing list archive

[Bug 1363257] Re: string matching for dpkg I/O errors in dpkgpm.cc is out of date

 

Reviewing the strings returned by lib/dpkg/buffer.c the following patch
should resolve the issue, although this is still not ideal.

 $ bzr cdiff
=== modified file 'apt-pkg/deb/dpkgpm.cc'
--- apt-pkg/deb/dpkgpm.cc       2014-06-10 19:00:00 +0000
+++ apt-pkg/deb/dpkgpm.cc       2014-08-29 20:41:09 +0000
@@ -1668,9 +1668,10 @@
    // do not report dpkg I/O errors, this is a format string, so we compare
    // the prefix and the suffix of the error with the dpkg error message
    vector<string> io_errors;
-   io_errors.push_back(string("failed to read on buffer copy for %s"));
-   io_errors.push_back(string("failed in write on buffer copy for %s"));
-   io_errors.push_back(string("short read on buffer copy for %s"));
+   io_errors.push_back(string("failed to read"));
+   io_errors.push_back(string("failed to write"));
+   io_errors.push_back(string("failed to seek"));
+   io_errors.push_back(string("unexpected end of file or stream"));
 
    for (vector<string>::iterator I = io_errors.begin(); I != io_errors.end(); ++I)

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to apt in Ubuntu.
https://bugs.launchpad.net/bugs/1363257

Title:
  string matching for dpkg I/O errors in dpkgpm.cc is out of date

Status in “apt” package in Ubuntu:
  New

Bug description:
  The following error strings are no longer returned by dpkg:

     io_errors.push_back(string("failed to read on buffer copy for %s"));
     io_errors.push_back(string("failed in write on buffer copy for %s"));
     io_errors.push_back(string("short read on buffer copy for %s"));

  Subsequently, apport package installation failures are being created
  for these types of crashes and they should not be.  Additionally,
  there is a new error returned by dpkg ("unexpected end of file or
  stream" as seen in bug 1361489) which should also be blocked.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/apt/+bug/1363257/+subscriptions


References