touch-packages team mailing list archive

[Rodney Dawes <1270969@xxxxxxxxxxxxxxxxxx>]

** Changed in: ubuntuone-credentials (Ubuntu)
       Status: New => Triaged

** Changed in: ubuntuone-credentials (Ubuntu)
   Importance: Undecided => High

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to ubuntuone-credentials in
Ubuntu.
https://bugs.launchpad.net/bugs/1270969

Title:
  Network class leaks _request variable

Status in ubuntuone-credentials package in Ubuntu:
  Triaged

Bug description:
  via valgrind:

  ==17330== 353 (4 direct, 349 indirect) bytes in 1 blocks are definitely lost in loss record 1,234 of 1,272
  ==17330==    at 0x402A05C: operator new(unsigned int) (in /usr/lib/valgrind/vgpreload_memcheck-x86-linux.so)
  ==17330==    by 0x45F14D4: UbuntuOne::Network::Network(QObject*) (network.cpp:38)
  ==17330==    by 0x45EF91A: UbuntuOne::IdentityProvider::IdentityProvider(QObject*) (identityprovider.cpp:31)
  ==17330==    by 0x45E329F: UbuntuOne::SSOService::SSOService(QObject*) (ssoservice.cpp:35)
  ==17330==    by 0x4609906: ClickScope::DownloadManager::DownloadManager(QObject*) (download-manager.cpp:44)
  ==17330==    by 0x8051F28: char TestRunner::RegisterTest<TestDownloadManager>(char*) (test_download_manager.h:101)
  ==17330==    by 0x804D1AA: _GLOBAL__sub_I__ZN23TestableDownloadManager25setShouldSignalCredsFoundEb (test_download_manager.h:137)
  ==17330==    by 0x8052E11: __libc_csu_init (in /home/mmccrack/src/unity-scope-click/cxx-dlmgr-tests/build/scope/tests/test-click-scope)
  ==17330==    by 0x4732899: (below main) (libc-start.c:219)

  
  from the code:

      /* either shared pointer or delete this */
      _nam = new QNetworkAccessManager(this);
      _request = new QNetworkRequest();

  why not pass this as parent to QNetworkRequest?

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntuone-credentials/+bug/1270969/+subscriptions