touch-packages team mailing list archive

[Daniel van Vugt <daniel.van.vugt@xxxxxxxxxxxxx>]

** Also affects: mir (Ubuntu)
   Importance: Undecided
       Status: New

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to mir in Ubuntu.
https://bugs.launchpad.net/bugs/1450797

Title:
  mir::input::Surface::consume(MirEvent const& event) should not take a
  reference to an opaque type

Status in Mir:
  Fix Committed
Status in mir package in Ubuntu:
  New

Bug description:
  MirEvent has been made opaque in the public API and all use of it in
  user code should be by way of the mir_event_...(MirEvent*) functions.

  As we are publishing include/server/mir/input/surface.h the void
  consume(MirEvent const& event) function in this interface ought to
  have a consistent interface and take a pointer: void consume(MirEvent
  const* event)

  This avoids clients (and our own tests) needing hacks like this:

      MOCK_METHOD1(consume, void(MirEvent const* event));
      void consume(MirEvent const& event) override { consume(&event); }

To manage notifications about this bug go to:
https://bugs.launchpad.net/mir/+bug/1450797/+subscriptions