← Back to team overview

touch-packages team mailing list archive

[Bug 1262491] Re: No line numbers for valgrind with --coverage

 

** Changed in: unity-scopes-api (Ubuntu)
       Status: New => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to unity-scopes-api in
Ubuntu.
https://bugs.launchpad.net/bugs/1262491

Title:
  No line numbers for valgrind with --coverage

Status in API for Unity scopes integration:
  Fix Released
Status in “unity-scopes-api” package in Ubuntu:
  Fix Released

Bug description:
  If the code is built with -DCMAKE_BUILD_TYPE=coverage, and I run "make
  valgrind", valgrind runs and does the right thing. However, if a test
  has a valgrind problem, the stack trace produced by valgrind doesn't
  contain line numbers. On the other hand, if I build with
  -DCMAKE_BUILD_TYPE=debug, valgrind reports line numbers as expected.

  In CMakeLists.txt, we have:

  if(cmake_build_type_lower MATCHES coverage)
      set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} --coverage")
      set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} --coverage")
      set(CMAKE_MODULE_LINKER_FLAGS "${CMAKE_MODULE_LINKER_FLAGS} --coverage")
      set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} --coverage")
      set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} --coverage")

      # We add -g when building with coverage so valgrind reports line numbers.
      set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -g" )
      set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -g" )
  endif()

  However, when I build with make VERBOSE=1, only --coverage appears in
  the flags, -g is missing. It's not clear to me why -g gets clobbered.
  Moreover, this same thing used to work a few weeks back.

  Anyone have any idea?

To manage notifications about this bug go to:
https://bugs.launchpad.net/unity-scopes-api/+bug/1262491/+subscriptions