touch-packages team mailing list archive

[Zoltan Balogh <zoltan.balogh@xxxxxxxxxxxxx>]

** Changed in: ubuntu-ui-toolkit (Ubuntu)
       Status: New => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to ubuntu-ui-toolkit in
Ubuntu.
https://bugs.launchpad.net/bugs/1316631

Title:
  New header doesn't take actions visibility into account

Status in Ubuntu UI Toolkit:
  Fix Released
Status in “ubuntu-ui-toolkit” package in Ubuntu:
  Fix Released

Bug description:
  In messaging-app we switch the visibility of some actions under some situations .
  Ie: we only display the "Add contact" button if the contact is unknown, we only display the "Show profile" if the contact is known, 
  we only display the "selection mode" action if there is at least one message.

  The ToolbarItems {} has at least 5 actions in total, but they are not all displayed at the same time. We switch the visibility on demand. I see that even when there are no visible actions, the overflow icon still appears in the header.
  I suppose it is taking into account the number of actions instead of visible actions in order to display the overflow icon.

  Having different sets of ToolbarItems for each situation would work
  but increases the code complexity and would require apps to duplicate
  code internally as a particular action could be present in different
  situations, like the "Call button" which is present no matter if the
  contact is known or unknown.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1316631/+subscriptions