touch-packages team mailing list archive

[Martin Pitt <martin.pitt@xxxxxxxxxx>]

I'm not quite sure why *this* bug got closed with that upload. Both the
changelog and the bzr commit refer to bug 1345569. Reopening.

** Changed in: apport (Ubuntu)
       Status: Fix Released => Triaged

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to apport in Ubuntu.
https://bugs.launchpad.net/bugs/1376374

Title:
  whoopsie-upload-all will run hooks on a corrupt crash file multiple
  times

Status in “apport” package in Ubuntu:
  Fix Released

Bug description:
  whoopsie-upload-all in it's process_report() function will try to
  collect information for a crash with a truncated core dump every time
  it is called thereby wasting resources on a device.

  I'm looking at the following code:

      if 'Dependencies' in r:
          print('%s already has info collected' % report)
      else:
          print('Collecting info for %s...' % report)
          r.add_os_info()
          # add minimal hook information here; whoopsie only considers
          # ApportVersion, NonfreeKernelModules, SystemImageInfo
          try:
              r.add_hooks_info(None)
          except Exception as e:
              sys.stderr.write('WARNING: hook failed for processing %s: %s\n' % (report, str(e)))

          try:
              r.add_gdb_info()
          except (IOError, EOFError) as e:
              sys.stderr.write('ERROR: processing %s: %s\n' % (report, str(e)))
              return None

  Because the report is never written Dependencies is never added to the
  report, so every time whoopsie-upload-all is called it will run
  add_hooks_info() and add_gdb_info() for the same report.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/apport/+bug/1376374/+subscriptions