touch-packages team mailing list archive

[Pawel Stolowski <1381971@xxxxxxxxxxxxxxxxxx>]

After looking at the code of shell plugin and some more debugging I
found the responsible snippet of code in the plugin (scope.cpp):

    bool containsDepartments = m_rootDepartment.get() != nullptr;
    // design decision - no navigation when doing searches
    containsDepartments &= m_searchQuery.isEmpty();

    if (containsDepartments != m_hasNavigation) {
        m_hasNavigation = containsDepartments;
        Q_EMIT hasNavigationChanged();
    }

    if (!containsDepartments && !m_currentNavigationId.isEmpty()) {
        m_currentNavigationId = "";
        Q_EMIT currentNavigationIdChanged();
    }

Unfortunately that means we cannot pass department and non-empty query
string because search needs to be global, and not within a department
(design decision affecting all scopes) and shell plugin resets
department id if that happens. I think this behavior of plugin is
questionable and needs to be re-considered, but any change here affects
all scopes.

The fix for this particular bug should therefore happen in mediascanner
scope.

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to unity-scopes-shell in
Ubuntu.
https://bugs.launchpad.net/bugs/1381971

Title:
  Selecting artists from "My Music" scope doesn't show
  "albums_of_artist" view anymore

Status in Unity Media Scanner Scope:
  New
Status in “unity-scope-mediascanner” package in Ubuntu:
  Confirmed
Status in “unity-scopes-shell” package in Ubuntu:
  Invalid

Bug description:
  I was able to reproduce this problem with ubuntu-rtm image #91 for
  Nexus 4:

  version_detail:
  ubuntu=20141016,device=20140929.1,custom=mako-1.1,version=91

  Steps to reproduce:

  1. Load some music onto device
  2. Navigate to "My Music" scope in dash (e.g. by clicking the "My Music" category header in music scope).
  3. Select an artist from the surfacing results

  Observed behaviour:
  Standard search results for the artist's name are displayed with small icons for artists, albums and tracks.

  Expected behaviour:
  The special "albums_of_artist" view should be displayed with a full width result showing art for the artist.

  Surprisingly, if I select the same artist result as it appears in the
  music aggregator scope, I get the albums_of_artist view.  This makes
  me suspect that this is a problem in the dash or unity-scopes-shell,
  where the department ID from the canned query is being lost.

To manage notifications about this bug go to:
https://bugs.launchpad.net/unity-scope-mediascanner/+bug/1381971/+subscriptions