touch-packages team mailing list archive

[Zsombor Egri <1330510@xxxxxxxxxxxxxxxxxx>]

Not checked with Valgrind, however the binding loops on properties were
still there with the fix. The auto-theming got moved into MainView and
is only applied for system themes.

** Changed in: ubuntu-ui-toolkit (Ubuntu)
       Status: Confirmed => In Progress

** Changed in: ubuntu-ui-toolkit (Ubuntu)
   Importance: Undecided => High

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to ubuntu-ui-toolkit in
Ubuntu.
https://bugs.launchpad.net/bugs/1330510

Title:
  Valgrind warning when theme is changed from MainViewStyle.qml

Status in “ubuntu-ui-toolkit” package in Ubuntu:
  In Progress

Bug description:
  We are getting this warning in valgrind (with Qt 5.3)

  ==20334== Invalid read of size 8
  ==20334==    at 0x581568A: QQmlObjectCreator::finalize(QQmlInstantiationInterrupt&) (qrecursionwatcher_p.h:94)
  ==20334==    by 0x57A5A82: QQmlIncubatorPrivate::incubate(QQmlInstantiationInterrupt&) (qqmlincubator.cpp:357)
  ==20334==    by 0x57A6215: QQmlEnginePrivate::incubate(QQmlIncubator&, QQmlContextData*) (qqmlincubator.cpp:95)
  ==20334==    by 0x57A169C: QQmlComponent::create(QQmlIncubator&, QQmlContext*, QQmlContext*) (qqmlcomponent.cpp:1072)
  ==20334==    by 0x5DCE449: QQuickLoaderPrivate::_q_sourceLoaded() (qquickloader.cpp:721)
  ==20334==    by 0x5DCE5E7: QQuickLoaderPrivate::load() (qquickloader.cpp:604)
  ==20334==    by 0x581564D: QQmlObjectCreator::finalize(QQmlInstantiationInterrupt&) (qqmlobjectcreator.cpp:1202)
  ==20334==    by 0x57A1076: QQmlComponentPrivate::complete(QQmlEnginePrivate*, QQmlComponentPrivate::ConstructionState*) (qqmlcomponent.cpp:932)
  ==20334==    by 0x57A1108: QQmlComponentPrivate::completeCreate() (qqmlcomponent.cpp:968)
  ==20334==    by 0x57A0FCF: QQmlComponent::create(QQmlContext*) (qqmlcomponent.cpp:795)
  ==20334==    by 0x5DD538E: QQuickView::continueExecute() (qquickview.cpp:489)
  ==20334==    by 0x5DD5AB3: QQuickViewPrivate::execute() (qquickview.cpp:133)
  ==20334==    by 0x407045: startShell(int, char const**, void*) (main.cpp:162)
  ==20334==    by 0x407A74: main (main.cpp:227)
  ==20334==  Address 0x20df8968 is 104 bytes inside a block of size 112 free'd
  ==20334==    at 0x4C2C2BC: operator delete(void*) (vg_replace_malloc.c:503)
  ==20334==    by 0x5815FB0: QQmlObjectCreator::~QQmlObjectCreator() (qqmlobjectcreator.cpp:156)
  ==20334==    by 0x57A52AA: QQmlIncubatorPrivate::clear() (qscopedpointer.h:62)
  ==20334==    by 0x57A53C6: QQmlIncubator::clear() (qqmlincubator.cpp:577)
  ==20334==    by 0x5DCD7CF: QQuickLoaderPrivate::clear() (qquickloader.cpp:95)
  ==20334==    by 0x5DCEB02: QQuickLoader::setSourceComponent(QQmlComponent*) (qquickloader.cpp:472)

  Because MainViewStyle.qml is replacing the theme once it gets loaded
  (if it needs to go Dark) and we're basically changing the component in
  MainView.qml while the component is being loaded and it seems Qt
  doesn't like that.

  Not sure if it could be argued this is a Qt 5.3 bug, haven't tried if
  the warning is there in Qt 5.2

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-ui-toolkit/+bug/1330510/+subscriptions