← Back to team overview

touch-packages team mailing list archive

[Bug 1392412] Re: may frequently try to upload reports when server responds with 400

 

** Description changed:

  parse_and_upload_report will return success = True on a 400 response
  from the server, however if for some reason the report is not marked as
  handled (mark_handled) then because there is no .uploaded file whoopsie
- will continuely try to upload the .crash file.
+ will continually try to upload the .crash file.
  
  from src/whoopsie.c:
  
          } else if (online_state && parse_and_upload_report (crash_file)) {
              if (!mark_handled (crash_file))
                  log_msg ("Unable to mark report as seen (%s)\n", crash_file);
  
          }
  
  Given that every crash report is not precious, we should just remove the
  crash_file if mark_handled fails.

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to whoopsie in Ubuntu.
https://bugs.launchpad.net/bugs/1392412

Title:
  may frequently try to upload reports when server responds with 400

Status in whoopsie package in Ubuntu:
  Fix Committed

Bug description:
  parse_and_upload_report will return success = True on a 400 response
  from the server, however if for some reason the report is not marked
  as handled (mark_handled) then because there is no .uploaded file
  whoopsie will continually try to upload the .crash file.

  from src/whoopsie.c:

          } else if (online_state && parse_and_upload_report (crash_file)) {
              if (!mark_handled (crash_file))
                  log_msg ("Unable to mark report as seen (%s)\n", crash_file);

          }

  Given that every crash report is not precious, we should just remove
  the crash_file if mark_handled fails.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/whoopsie/+bug/1392412/+subscriptions


References