touch-packages team mailing list archive

[Martin Pitt <martin.pitt@xxxxxxxxxx>]

This is the relevant GIR delta, for the record.

** Patch added: "relevant GIR diff"
   https://bugs.launchpad.net/ubuntu/+source/libnotify/+bug/1223401/+attachment/4292819/+files/gir.diff

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to libnotify in Ubuntu.
https://bugs.launchpad.net/bugs/1223401

Title:
  [0.7.6] the add_action api changed creating issues for clients

Status in libnotify package in Ubuntu:
  Confirmed

Bug description:
  That upstream change seems an api change:
  https://git.gnome.org/browse/libnotify/commit/?id=2b4ab4d22f42dd264a4ddfa68b02bba0d6c71b0b

  Simple testcase:

  "from gi.repository import GLib, Notify

  def action_callback():
      print action_id
  notification = Notify.Notification.new("", "", "")
  notification.add_action("one", "two", action_callback, None, None)"

  that code worked before and is complaining about the number of
  arguments (5 instead of 6) after the update

  We reverted the change because it was creating problems in unity8
  tests (and likely in code in the archive).

  Before dropping the revert we should probably figure out if:
  - the upstream change is correct is buggy
  - why the number of argument changed (it seems from the commit it shouldn't)
  - what in the archive use that api and needs to be ported
  - how we can make code support both old/new apis at the same time

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/libnotify/+bug/1223401/+subscriptions