touch-packages team mailing list archive

[Michael Sheldon <michael.sheldon@xxxxxxxxxxxxx>]

I've linked a branch with a proposed fix that removes the use of the
timer when the orientationAngle is being set explicitly rather than from
the screen orientation/primaryOrientation, which solves the issue from
the keyboard's perspective (since it follows the application
orientation).

This doesn't solve the issue for any apps using automatic orientation
that want to rely on the orientationAngleChanged signal as an indicator
that the orientation has actually changed though.

** Description changed:

  The rewritten OrientationHelper that was merged into trunk here:
  http://bazaar.launchpad.net/~ubuntu-sdk-team/ubuntu-ui-
  toolkit/trunk/revision/1147 introduces a new 250ms timer to prevent
  incorrect rotations caused by Screen.primaryOrientation and
  Screen.orientation being set one after another. However this prevents
  applications from being able to rely on the changes to the angle having
- been applied via onOrientationAngleChanged (since they now only get
- applied 250ms after the orientation change happens).
+ been applied via the orientationAngleChanged signal (since they now only
+ get applied 250ms after the orientation change happens).
  
  Because the keyboard changes its orientation based on the application
  orientation this results in the keyboard rotating 250ms after the
  application has rotated, and more problematically means that the input
- area reported by the keyboard after the onOrientationAngleChanged being
- incorrect (as the orientation change hasn't actually happened).
+ area reported by the keyboard after the orientationAngleChanged signal
+ being incorrect (as the orientation change hasn't actually happened).
  
  Steps to reproduce
  
  1) Open the browser
  
  2) Tab the address bar
  
  3) Rotate the phone
  
  Expected outcome
  
  All keys on the keyboard can be pressed
  
  Actual outcome
  
  Only keys in the old input area can be pressed because the new input
  area hasn't been reported.

** Description changed:

  The rewritten OrientationHelper that was merged into trunk here:
  http://bazaar.launchpad.net/~ubuntu-sdk-team/ubuntu-ui-
  toolkit/trunk/revision/1147 introduces a new 250ms timer to prevent
  incorrect rotations caused by Screen.primaryOrientation and
  Screen.orientation being set one after another. However this prevents
  applications from being able to rely on the changes to the angle having
  been applied via the orientationAngleChanged signal (since they now only
  get applied 250ms after the orientation change happens).
  
  Because the keyboard changes its orientation based on the application
  orientation this results in the keyboard rotating 250ms after the
  application has rotated, and more problematically means that the input
  area reported by the keyboard after the orientationAngleChanged signal
- being incorrect (as the orientation change hasn't actually happened).
+ is incorrect (as the orientation change hasn't actually happened).
  
  Steps to reproduce
  
  1) Open the browser
  
  2) Tab the address bar
  
  3) Rotate the phone
  
  Expected outcome
  
  All keys on the keyboard can be pressed
  
  Actual outcome
  
  Only keys in the old input area can be pressed because the new input
  area hasn't been reported.

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to ubuntu-ui-toolkit in
Ubuntu.
https://bugs.launchpad.net/bugs/1409027

Title:
  Timer in rewritten OrientationHelper breaks keyboard orientation

Status in ubuntu-ui-toolkit package in Ubuntu:
  New

Bug description:
  The rewritten OrientationHelper that was merged into trunk here:
  http://bazaar.launchpad.net/~ubuntu-sdk-team/ubuntu-ui-
  toolkit/trunk/revision/1147 introduces a new 250ms timer to prevent
  incorrect rotations caused by Screen.primaryOrientation and
  Screen.orientation being set one after another. However this prevents
  applications from being able to rely on the changes to the angle
  having been applied via the orientationAngleChanged signal (since they
  now only get applied 250ms after the orientation change happens).

  Because the keyboard changes its orientation based on the application
  orientation this results in the keyboard rotating 250ms after the
  application has rotated, and more problematically means that the input
  area reported by the keyboard after the orientationAngleChanged signal
  is incorrect (as the orientation change hasn't actually happened).

  Steps to reproduce

  1) Open the browser

  2) Tab the address bar

  3) Rotate the phone

  Expected outcome

  All keys on the keyboard can be pressed

  Actual outcome

  Only keys in the old input area can be pressed because the new input
  area hasn't been reported.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-ui-toolkit/+bug/1409027/+subscriptions