← Back to team overview

touch-packages team mailing list archive

[Bug 1356222] Re: [MIR] fcitx and related packages

 

General comment: why resetting  fcitx-hangul, fcitx-m17n, fcitx-
sunpinyin and fcitx-table-extra from incomplete to confirmed? Seems that
no release to fix the blockers have been uploaded, so previous state
remains the same. Please get an upstream release and an upload to ubuntu
to fix the blockers before turning that state.

---

-> fcitx:
* NEEDS FIXING: transitional packages like fcitx-libs-gclient, fcitx-libs-qt and fcitx-libs:
- please remove the whole description stenza in debian/control and use a snippet like in https://wiki.debian.org/Renaming_a_Package (Method 2):
 Description: transitional dummy package
  This is a transitional dummy package. It can safely be removed.
This will avoid puzzling the users between the 2 packages if they are equivalent (which seems to be the case, as they just depends on the other package).
- its section should be oldlibs
- also, please update the recommends/depends from other package (they still depend on the transitional package): fcitx-libs: Recommends: fcitx-libs-gclient (>= ${source:Version}). It should be on libfcitx-gclient0.

* NEEDS FIXING: I guess the autostart binary (in fcitx-bin) shouldn't be
in usr/bin, but more in an exec path like libexec for instance. You told
upstream liked the idea, any news since september for a release with
this? I would prefer that we don't pulling the user PATH with autostart
content.

* NEEDS INFO: IIRC, you told me that the .conf and .mk in fcitx-table-*
packages are arch dependent (they are shipped in arch-dependent package
anyway). If this is the case, they shouldn't be installed in usr/share
as it's a policy violation and should rather be in libexec.

---

-> fcitx-anthy:
* MINOR: debian/copyright miss some more fixes:
src/preedit.cpp: Copyright: 2004-2005 Takuro Ashie / 2012 CSSlayer
src/action.*: miss Copyright: 2012 CSSlayer

---

-> fcitx-cloudpinyin
Ack, putting to Fix committed

---

-> fcitx-configtool
Ack, putting to Fix committed

---

-> fcitx-googlepinyin
Ack, putting to Fix committed

---

-> fcitx-hangul
2 issues fixed in debian git, but no upload for this yet since september. Needs an ubuntu upload for this:
* The package is multi-arch and should be marked as such in debian/control (http://anonscm.debian.org/cgit/pkg-ime/fcitx-hangul.git/commit/?id=0d4418f3a35e1346f6c4461d3eb5d97016e4f002)
* missing Copyright: 2012 CSSlayer <wengxt@xxxxxxxxx> -> should be 2010-2012 (http://anonscm.debian.org/cgit/pkg-ime/fcitx-hangul.git/commit/?id=648c746466c92d6b9a86a5d4bcade691e57b2f86)

---

-> fcitx-m17n:
2 issues fixed in debian git, but no upload for this yet since september. Needs an ubuntu upload for this:
* The package is multi-arch and should be marked as such in debian/control (http://anonscm.debian.org/cgit/pkg-ime/fcitx-m17n.git/commit/?id=15108dfe41f329f4bb041ca96f2dbebda117ec24)
* missing   Copyright: 1995-1997 Peter Mattis, Spencer Kimball and Josh MacDonald in im/keysymname.c (http://anonscm.debian.org/cgit/pkg-ime/fcitx-
>>> m17n.git/commit/?id=9d981e902b048bc3cdb74d94b15ab896ae8029da)

---

-> fcitx-qimpanel:
* NEEDS FIXING: I guess the autostart binary shouldn't be in usr/bin, but more in an exec path like libexec for instance. You told upstream liked the idea, any news since september for a release with this? I would prefer that we don't pulling the user PATH with autostart content.

---

-> fcitx-qt5:
* BLOCKER: Still no release with the COPYING for GPL2 nor LGPL2. Both are needed to be shipped upstream in a release that we package in ubuntu (https://github.com/fcitx/fcitx-qt5/issues/4).

* NEEDS INFO: it seems that fcitx-libs-qt5 and fcitx-libs-qt5-dev are now just transitional packages, right (it's empty, have the dep/recommends similar to the replacing package)? If so, please remove the whole description stenza and use a snippet like in https://wiki.debian.org/Renaming_a_Package (Method 2):
 Description: transitional dummy package
  This is a transitional dummy package. It can safely be removed.
and Section: oldlibs
Also, the Breaks/Replaces should be versioned.
This will avoid puzzling the users between the 2 packages if they are equivalent (which seems to be the case, as they just depends on the other package).


---

-> fcitx-sunpinyin:
* previous copyright BLOCKERS in debian git, but no upload since.

---

-> fcitx-table-extra:
* BLOCKER: tables/scj6.txt is GPL3, there is no COPYING file mentionning GPL3. You need upstream to ship it.
-> Still waiting for a release (https://github.com/fcitx/fcitx/issues/170) with the fixed version

* BLOCKER (was a NEEDS FIXING and turning as a BLOCKER now with gtk3 not doing the scaling anymore for you, like in unity dash):
W: fcitx-table-cantonese: icon-size-and-directory-name-mismatch usr/share/icons/hicolor/64x64/apps/fcitx-cantonese.png 48x48
W: fcitx-table-stroke5: icon-size-and-directory-name-mismatch usr/share/icons/hicolor/64x64/apps/fcitx-stroke5.png 48x48
W: fcitx-table-zhengma: icon-size-and-directory-name-mismatch usr/share/icons/hicolor/48x48/apps/fcitx-zhengma.png 64x64

* NEEDS FIXING: debian/rules:
Mind adding a small comment in debian/rules as in -other explaining the reason of stripping the .mo file

---

-> fcitx-table-other:
comment added to git, LGTM.

---

-> libgooglepinyin:
* NEEDS FIXING: FTBFS on armhf, i386 and powerpc

---

-> presage:
* MINOR: any reason why presage priority is extra?
* NEEDS INFO: will python-presage be used? If so, it needs to be a python3 package in addition to the current python2 one as we now have main almost fully supporting python3. Also, please not that this binary package (if put in main) depends on python-wxgtk2.8, not in main.

---

-> tinyxml:
* NEEDS INFO: We already have multiple xml libraries in main. Any chance to switch the build-dep on that one to another one, like the boost lib?
(was already asked, but didn't get an answer if I'm right on that one)
Otherwise, the package itself is fine, status depending on the above answer.


----
On a final note, can you ensure that all those packages have the desktop bug team as a suscriber for tracking them?


** Changed in: fcitx-cloudpinyin (Ubuntu)
       Status: Confirmed => Fix Committed

** Changed in: fcitx-configtool (Ubuntu)
       Status: Confirmed => Fix Committed

** Changed in: fcitx-googlepinyin (Ubuntu)
       Status: Confirmed => Fix Committed

** Changed in: fcitx-table-other (Ubuntu)
       Status: Confirmed => Fix Committed

** Changed in: fcitx (Ubuntu)
       Status: Confirmed => Incomplete

** Changed in: fcitx-anthy (Ubuntu)
       Status: Confirmed => Incomplete

** Changed in: fcitx-hangul (Ubuntu)
       Status: Confirmed => Incomplete

** Changed in: fcitx-m17n (Ubuntu)
       Status: Confirmed => Incomplete

** Changed in: fcitx-qimpanel (Ubuntu)
       Status: Confirmed => Incomplete

** Changed in: fcitx-qt5 (Ubuntu)
       Status: Confirmed => Incomplete

** Changed in: fcitx-sunpinyin (Ubuntu)
       Status: Confirmed => Incomplete

** Changed in: fcitx-table-extra (Ubuntu)
       Status: Confirmed => Incomplete

** Changed in: libgooglepinyin (Ubuntu)
       Status: Confirmed => Incomplete

** Changed in: presage (Ubuntu)
       Status: Confirmed => Incomplete

** Changed in: tinyxml (Ubuntu)
       Status: New => Incomplete

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to tinyxml in Ubuntu.
https://bugs.launchpad.net/bugs/1356222

Title:
  [MIR] fcitx and related packages

Status in fcitx package in Ubuntu:
  Incomplete
Status in fcitx-anthy package in Ubuntu:
  Incomplete
Status in fcitx-chewing package in Ubuntu:
  Fix Committed
Status in fcitx-cloudpinyin package in Ubuntu:
  Fix Committed
Status in fcitx-configtool package in Ubuntu:
  Fix Committed
Status in fcitx-googlepinyin package in Ubuntu:
  Fix Committed
Status in fcitx-hangul package in Ubuntu:
  Incomplete
Status in fcitx-m17n package in Ubuntu:
  Incomplete
Status in fcitx-qimpanel package in Ubuntu:
  Incomplete
Status in fcitx-qt5 package in Ubuntu:
  Incomplete
Status in fcitx-sunpinyin package in Ubuntu:
  Incomplete
Status in fcitx-table-extra package in Ubuntu:
  Incomplete
Status in fcitx-table-other package in Ubuntu:
  Fix Committed
Status in libgooglepinyin package in Ubuntu:
  Incomplete
Status in presage package in Ubuntu:
  Incomplete
Status in tinyxml package in Ubuntu:
  Incomplete

Bug description:
  [Availability]
  Currently in universe

  [Rationale]
  Fcitx is a replacement candidate for IBus

  [Security: ]
  CVE entries: none
  Security history: none
  Any binaries running as root or suid/sgid ? Any daemons ?
      -- all running as per user session, and /usr/bin/fcitx and /usr/bin/fcitx-qimpanel will run as daemon, /usr/bin/fcitx-dbus-watcher will be pulled up when fcitx is running.
  Network activity: does it open any port ? Does it handle incoming network data ?
      -- fcitx-cloudpinyin deals with network data by using libcurl and interact with remote API from several user-choosable providers.
  Does it directly (not through a library) process binary (video, audio, etc) or structured (PDF, etc) data ?
      -- no, it doesn't
  Any source code review performed ? (The approver will do a quick and shallow check.)
      -- no.

  [Quality Assurance]
  Package works out of the box with no prompting.
  There is no reproducible major bugs in Ubuntu and Debian.
  Upstream is active.
  Package is team maintained at Debian, and is the same people working on Debian and Ubuntu.

  Upstream bug tracker: https://github.com/fcitx/fcitx
  Hardware: Does this package deal with hardware and if so how exotic is it ?
      -- no
  Is there a test suite in the upstream source or packaging ? Is it enabled to run in the build ?
      -- yes, some fundamental tests

  [UI standards]
      User-visible strings are internationalized using standard gettext system ?
          -- yes
      Package with translatable strings builds a PO template during package build ?
          -- yes
      End-user applications ship a desktop file?
          -- fcitx and fcitx-ui-qimpanel do.

  [Standards Compliance]
  FHS and Debian Policy compliant.
  Packaging system (debhelper/cdbs/dbs) ? Patch system ? Any packaging oddities ?
      -- package is using debhelper,

  [Maintenance]
  Desktop Team will take care of them

  [Dependencies]
  librime and brise are for fcitx-rime.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/fcitx/+bug/1356222/+subscriptions


Follow ups