touch-packages team mailing list archive

[David Lang <david@xxxxxxx>]

It would actually be better to honor the sysadmins instruction and
install the untrusted packages rather than adding the packages to the
blacklist


--- /usr/bin/unattended-upgrade 2014-04-02 13:52:19.000000000 -0700
+++ /usr/bin/unattended-upgrade.local   2015-01-15 17:26:47.273378190 -0800
@@ -1028,7 +1028,8 @@
                 logging.error("Download finished, but file '%s' not "
                               "there?!?" % item.destfile)
                 sys.exit(1)
-            if not item.is_trusted:
+            if not item.is_trusted and not apt_pkg.config.find_b(
+                "APT::Get::AllowUnauthenticated", True):
                 blacklisted_pkgs.append(pkgname_from_deb(item.destfile))
             if conffile_prompt(item.destfile):
                 # skip package (means to re-run the whole marking again

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to unattended-upgrades in
Ubuntu.
https://bugs.launchpad.net/bugs/1167053

Title:
  untrusted packages silently added to blacklist

Status in unattended-upgrades package in Ubuntu:
  Confirmed

Bug description:
  Packages that are not trusted are added to the blacklist but no reason
  is ever printed out while running in debug mode causing confusion as
  to why a package would be blacklisted until you dig into the source.

  Release: All versions
  Package: All versions

  Expected behavior: Print out debug message that informs user package was blacklisted due to not being trusted
  Actual behavior: Message saying package is blacklisted without reason

  Still trying to figure out how to properly upload a patch to this, but
  basically just adding

  logging.debug("%s blacklisted because it's not trusted" %
  pkgname_from_deb(item.destfile))

  to line 946 would suffice

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/unattended-upgrades/+bug/1167053/+subscriptions