← Back to team overview

touch-packages team mailing list archive

[Bug 1418060] Re: [FFe] QML compilation cache patch needs adaptation for Qt 5.4

 

Patch headers added. Upstream discussion is currently being planned,
there should be enough time to discuss and get it to Qt 5.6 which will
have feature freeze somewhere around July.

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to qtdeclarative-opensource-
src in Ubuntu.
https://bugs.launchpad.net/bugs/1418060

Title:
  [FFe] QML compilation cache patch needs adaptation for Qt 5.4

Status in qtdeclarative-opensource-src package in Ubuntu:
  In Progress

Bug description:
  -- FFe --

  Since we're past the feature freeze, bringing this patch back needs an exception, even though it's a regression fix at the same time. Summary:
  - The patch allows opt-in, environment variable controlled use of storing some cache data when loading QML files. Without the environment variable there are no changes.
  - Not having the patch is a performance regression on application startup time on the phones from Qt 5.3.2.
  - The patch already shipped in Qt 5.3.2, but needed adjustments for 5.4 that were not done on time when Qt 5.4 was otherwise ready to land before feature freeze, so the patch was commented out.
  - The patch is also shipping on the sold Bq phones.
  - The proposed changes are in the MP below, that is uncommenting the patch in debian/patches/series and the rebasing (the full patch is 25 files changed, 703 insertions(+), 14 deletions(-)).

  As usual, we have a wide testing being done also on this rebased-to-
  Qt-5.4.0 patch.

  Upstreaming is being considered now that the patch seems to work for
  our purposes. It might need more than code discussions since upstream
  developer is also selling a proprietary product that offers somewhat
  similar benefits.

  -- Original bug report --

  The environment variable controlled new functionality provided by QML
  compilation cache patch (landed for Qt 5.3.2) needs adaptation for Qt
  5.4, as it does not currently apply.

  Attachment shows a summary of the patch applying problems.

  More information about Qt 5.4 at
  https://wiki.ubuntu.com/Touch/QtTesting

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/qtdeclarative-opensource-src/+bug/1418060/+subscriptions


References