touch-packages team mailing list archive

[Gunnar Hjalmarsson <678421@xxxxxxxxxxxxxxxxxx>]

Hi Daniel,

Thanks for your comments!

On 2015-02-25 19:56, Daniel Hahler wrote:
>     set -x
>     exec 1>>$logfile
>     exec 2>>$logfile

Really using the "exec" command in ~/.profile would stop the execution
of the main process (/usr/sbin/lightdm-session), so I suppose your
~/.profile did not literally contain the above lines. To understand if
it was a false positive, you need to tell us more.

As regards kdialog: Right, just checking if kdialog is installed is
certainly not a safe way to detect a KDE system. OTOH, that's not really
the intention here. Given that you seem to have kdialog installed, does
it matter much if it's used to show the error dialog (in case of an
error) instead of xenity? ;)

If you want to suggest that the code is changed somehow, I ask you to
please file a new bug report, since it would be a little messy to handle
it on this already pretty long report.

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to lightdm in Ubuntu.
https://bugs.launchpad.net/bugs/678421

Title:
  Error message for a faulty ~/.profile script

Status in GDM: The Gnome Display Manager:
  New
Status in gdm package in Ubuntu:
  Fix Released
Status in lightdm package in Ubuntu:
  Fix Released
Status in gdm source package in Trusty:
  Fix Released
Status in lightdm source package in Trusty:
  Fix Released
Status in gdm source package in Utopic:
  Fix Released
Status in lightdm source package in Utopic:
  Fix Committed
Status in gdm package in Debian:
  New

Bug description:
  trusty and utopic SRU requests
  ==============================

  [Impact]

  In case of a syntax error in either of ~/.profile or a few other
  similar files, the Xorg login is interrupted, and the user is taken
  back to the login screen without an explanation. Debugging this
  problem may be a time consuming exercise, especially for non-
  experienced users.

  With the proposed change, lightdm/gdm does not try to load such a
  file, but shows a warning dialog instead. (A warning dialog is also
  shown in case of some other type of error, which would not have caused
  the login to fail.)

  [Test Case]

  To reproduce:

  * Edit ~/.profile and add something bad, e.g. a non-closed parenthesis.
  * Log out and find that you can't log in to a graphical session.

  After installing the proposed lightdm/gdm version, you'll instead see
  the dialog and can log in.

  [Regression Potential]

  Since this is only about improved exception handling, it does not at
  all affect users with correct configuration files. The regression risk
  ought to be minimal.

  [Original description]

  Binary package hint: gdm

  After adding "function AddPath { PATH="$1:$PATH" }" to $HOME/.profile
  made the Xorg startup fail. (At that moment I had already forgotten
  the changes made to the .profile). As I had autologin that meant it
  kept trying to login and finally showed me the graphics
  reconfiguration screen. That sent me to a huge hunt for xorg conf and
  setup problems.

  Anyway finally tracked this down. I had used bash syntax in .profile
  file whereas it was run with sh.

  This is not a bug per se but I think a user mistake in ".profile"
  shouldn't bring the whole xorg startup to a halt as it does with
  autologin. I propose running user ".profile" and ".xprofile" scripts
  so that Xsession script continues running even if they have errors.
  I'm not sure whether this change would have some negative effects as
  well.

  1) Ubuntu Lucid, Linux egon-laptop 2.6.32-25-generic #45-Ubuntu SMP Sat Oct 16 19:48:22 UTC 2010 i686 GNU/Linux
  2) gdm 2.30.2.is.2.30.0-0ubuntu4

To manage notifications about this bug go to:
https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions