touch-packages team mailing list archive

[Ricardo Salveti <rsalveti@xxxxxxxxxxxx>]

On Mon, Mar 9, 2015 at 1:38 PM, Didier Roche <didrocks@xxxxxxxxxx> wrote:
> * qtelepathy-qt5:
>
> debian/rules:
> - any change someone spend some time to look at the races in the failing tests and run them? (at least as adt tests).

This needs quite a bit of work, specially because it was disabled with
0.2.0-2 (and after enabling it again it seems the problems are still
there). Will ask Tiago and Boiko to take a look to see if they can at
least add that to their backlog.

> - optional, but please consider using dh_install --fail-missing
instead of --list-missing and rm in debian/tmp the file you don't want
to install, that helps controlling and ensuring we are building
everything we need.

Done

> debian/control: it's weird to have a build-depend as a metapackage
> (qt5-default), didn't we evolve the policy for other Qt5 packages IIRC,
> like depending on qtbase5-dev?

It's still required afaik, and that is still true for quite a few
other packages (just check the reverse-depends on it).

> Otherwise, this package looks good.
>
> * media-hub:
> debian/control:
> # We rely on C++11 features, and to prevent from ABI breaks
> # in libstdc++ causing us issues, we explicitly select a G++
> # version.
>                g++-4.9,
> -> is that still the case nowdays? I thought g++ stabilized their C++11 features ABI-break wise. Note for myself: this is also hardcoded in debian/rules.

Yes, after fighting with some really obscure issues during this cycle
we decided it's just better to force the compiler version, so I'd
prefer us to keep it.

> Package: media-hub pre-depends on dpkg, but isn't multi-arch or any
> postinst use any "more recent" dpkg features, can that be cleaned up? (I
> think even the other pre-depends on libmedia-hub* can be cleaned up now
> that trusty is out)

Done.

> I assume the security team already got a security pass at it?
>
> Apart from those nitpicks, looking good, keep me posted about the
> questions :)

Great, let me know if you need anything.

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to telepathy-qt5 in Ubuntu.
https://bugs.launchpad.net/bugs/1427958

Title:
  [MIR] media-hub

Status in media-hub package in Ubuntu:
  Incomplete
Status in telepathy-qt5 package in Ubuntu:
  Incomplete

Bug description:
  * Rationale

  Media-hub is a dependency of the new oxide-qt version. Media-hub
  provides a media server/service that is currently used by the Ubuntu
  Touch stack, and the dependency with Oxide was created in order for
  Oxide to support background playback (without letting the phone
  suspend, allowing the user to use websites such as grooveshark).

  * Dependencies

  Besides telepathy-qt5 (which is also included as a bug task), the
  remaining dependencies are all approved for main (dbus-cpp and
  process-cpp were moved back to universe but the MIR for them are
  already approved by bug 1218896 and bug 1270234).

  The dependency against telepathy-qt5 is required in order for the
  media-server to be allowed to react on telephony events (like stopping
  playback when receiving calls). Telepathy-qt5 is the same package as
  telepathy-qt, but built against the Qt 5 stack.

  * Maintenance:

  Media-hub is maintained by Ubuntu upstream (Phone Foundations team),
  and it is a core part of the Ubuntu Touch stack (main service
  responsible for multimedia playback).

  Telepathy-qt5 is currently maintained by the Ubuntu Touch Apps team,
  and also a core piece of the Ubuntu Touch stack.

  * Standard compliance:

  The packages are created according to our daily-build inline packaging
  rules and being daily-released in cu2d, so they comply to our Ubuntu
  packaging standards already.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/media-hub/+bug/1427958/+subscriptions