touch-packages team mailing list archive

[Bug Watch Updater <1428337@xxxxxxxxxxxxxxxxxx>]

Launchpad has imported 3 comments from the remote bug at
https://bugs.freedesktop.org/show_bug.cgi?id=89476.

If you reply to an imported comment from within Launchpad, your comment
will be sent to the remote bug automatically. Read more about
Launchpad's inter-bugtracker facilities at
https://help.launchpad.net/InterBugTracking.

------------------------------------------------------------------------
On 2015-03-06T19:34:36+00:00 Killertofu wrote:

Created attachment 114095
Patch to fix issue

If the command `upower -d` is run while a device with no history is
attached, the command can crash with a segfault.

Relevant backtrace when compiled from the master branch (f3706d7) with
debugging:

Program received signal SIGSEGV, Segmentation fault.
0x00007ffff76d8444 in g_variant_unref () from /usr/lib/libglib-2.0.so.0
(gdb) bt
#0  0x00007ffff76d8444 in g_variant_unref () from /usr/lib/libglib-2.0.so.0
#1  0x00007ffff7bc27b2 in up_device_get_history_sync (device=0x7ffff0003c70, 
    type=0x7ffff7bd23af "charge", timespec=120, resolution=10, cancellable=0x0, 
    error=0x0) at up-device.c:484
#2  0x00007ffff7bc192d in up_device_to_text_history (device=0x7ffff0003c70, 
    string=0x7ffff0001920, type=0x7ffff7bd23af "charge") at up-device.c:194
#3  0x00007ffff7bc2391 in up_device_to_text (device=0x7ffff0003c70)
    at up-device.c:375
#4  0x0000000000401d14 in main (argc=1, argv=0x7fffffffe748) at up-tool.c:321
(gdb) 

This appears to be caused by the fact that if the call to
'up_device_glue_call_get_history_sync' within the
'up_device_get_history_sync' function fails, the 'gva' variable will be
left uninitialized. The function later tries to call 'g_variant_unref'
on it and fails.

A patch which initializes 'gva' to NULL is attached and resolves the
issue for me. A similar fix may also be needed for the
'up_device_get_statistics_sync' function (which follows the same pattern
of leaving 'gva' uninitialized).

Reply at: https://bugs.launchpad.net/ubuntu/+source/mate-power-
manager/+bug/1428337/comments/8

------------------------------------------------------------------------
On 2015-03-13T12:21:20+00:00 Martin Pitt wrote:

*** Bug 89514 has been marked as a duplicate of this bug. ***

Reply at: https://bugs.launchpad.net/ubuntu/+source/mate-power-
manager/+bug/1428337/comments/9

------------------------------------------------------------------------
On 2015-03-13T12:23:36+00:00 Martin Pitt wrote:

I came here from a downstream report/patch, so I didn't take your patch,
sorry.

Fixed in master now:

http://cgit.freedesktop.org/upower/commit/?id=2510148b16

Thanks!

Reply at: https://bugs.launchpad.net/ubuntu/+source/mate-power-
manager/+bug/1428337/comments/10


** Changed in: upower
       Status: Unknown => Fix Released

** Changed in: upower
   Importance: Unknown => Medium

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to upower in Ubuntu.
https://bugs.launchpad.net/bugs/1428337

Title:
  MATE power statistics crashed

Status in Upower:
  Fix Released
Status in mate-power-manager package in Ubuntu:
  Invalid
Status in upower package in Ubuntu:
  Fix Committed
Status in upower package in Debian:
  New

Bug description:
  MATE Power Statistics will crash. Just click between a few tabs and
  power sources and it will soon die :(

  ProblemType: Crash
  DistroRelease: Ubuntu 15.04
  Package: mate-power-manager 1.8.1+dfsg1-3
  ProcVersionSignature: Ubuntu 3.19.0-7.7-generic 3.19.0
  Uname: Linux 3.19.0-7-generic x86_64
  ApportVersion: 2.16.2-0ubuntu1
  Architecture: amd64
  CurrentDesktop: MATE
  Date: Wed Mar  4 21:26:28 2015
  ExecutablePath: /usr/bin/mate-power-statistics
  InstallationDate: Installed on 2015-03-04 (0 days ago)
  InstallationMedia: Ubuntu-MATE 15.04 "Vivid Vervet" - Alpha amd64 (20150304)
  ProcCmdline: /usr/bin/mate-power-statistics --device /org/freedesktop/UPower/devices/battery_BAT0
  ProcEnviron:
   LANGUAGE=en_GB:en
   PATH=(custom, no user)
   XDG_RUNTIME_DIR=<set>
   LANG=en_GB.UTF-8
   SHELL=/bin/bash
  SegvAnalysis: Skipped: missing required field "Disassembly"
  Signal: 11
  SourcePackage: mate-power-manager
  UpgradeStatus: No upgrade log present (probably fresh install)
  UserGroups: adm cdrom dip lpadmin plugdev sambashare sudo

To manage notifications about this bug go to:
https://bugs.launchpad.net/upower/+bug/1428337/+subscriptions