touch-packages team mailing list archive

[Martin Pitt <martin.pitt@xxxxxxxxxx>]

This unescaping is already done by getmntent(). With an fstab entry like

  \\1.2.3.4\stuff /mnt/stuff cifs defaults,nofail 0 0

the me->mnt_fsname is \1.2.3.4\stuff. fstab uses \ as an escape
character, so I'm afraid this pretty much behaves as specified and you
have to escape \ too if you use them (i. e. use \\\\1.2.3.4...).

It's best to avoid those at all and use forward slashes for CIFS mounts.


** Changed in: systemd (Ubuntu)
       Status: Triaged => Invalid

** Changed in: systemd (Ubuntu)
     Assignee: Martin Pitt (pitti) => (unassigned)

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to systemd in Ubuntu.
https://bugs.launchpad.net/bugs/1440395

Title:
  fstab-generator interprets backslashes in CIFS mounts

Status in systemd:
  Confirmed
Status in systemd package in Ubuntu:
  Invalid

Bug description:
  Hello. I'm using systemd 219 on Ubuntu 15.04.
  I have the following line in /etc/fstab:

  \\192.168.1.110\ExtHDD /mnt/nas cifs vers=3.0,nofail,x-gvfs-
  show,credentials=/etc/nas_passwd,uid=1000,gid=1000,cache=loose 0 0

  "sudo mount /mnt/nas/" works properly in this case. Hovewer, fstab-
  generator creates an incorrect mount unit:

  # Automatically generated by systemd-fstab-generator

  [Unit]
  SourcePath=/etc/fstab
  Documentation=man:fstab(5) man:systemd-fstab-generator(8)

  [Mount]
  What=\192.168.1.110\ExtHDD
  Where=/mnt/nas
  Type=cifs
  Options=vers=3.0,nofail,x-gvfs-show,credentials=/etc/nas_passwd,uid=1000,gid=1000,cache=loose

  Note a missing backslash before the IP address. "systemctl status mnt-
  nas.mount" obviously tells that unit wasn't able to start:

  марта 31 20:23:32 artyom-H97-D3H mount[7360]: mount.cifs: bad UNC
  (\192.168.1.110\ExtHDD)

  Let's add more backslashes to the CIFS path:

  \\\\192.168.1.110\\ExtHDD /mnt/nas cifs vers=3.0,nofail,x-gvfs-
  show,credentials=/etc/nas_passwd,uid=1000,gid=1000,cache=loose 0 0

  In this case, generated mount unit is correct:

  # Automatically generated by systemd-fstab-generator

  [Unit]
  SourcePath=/etc/fstab
  Documentation=man:fstab(5) man:systemd-fstab-generator(8)

  [Mount]
  What=\\192.168.1.110\ExtHDD
  Where=/mnt/nas
  Type=cifs
  Options=vers=3.0,nofail,x-gvfs-show,credentials=/etc/nas_passwd,uid=1000,gid=1000,cache=loose

  However, mount commands refuses to work:

  $ sudo mount /mnt/nas 
  mount.cifs: bad UNC (\\\\192.168.1.110\\ExtHDD)

  I don't precisely know if fstab entries should contain escape
  characters (extra backslashes). Nonetheless, fstab-generator and mount
  command should have the same behaviour anyway.

  ProblemType: Bug
  DistroRelease: Ubuntu 15.04
  Package: systemd 219-6ubuntu1
  ProcVersionSignature: Ubuntu 3.19.0-9.9-generic 3.19.1
  Uname: Linux 3.19.0-9-generic x86_64
  NonfreeKernelModules: arc4 md4 nls_utf8 cifs fscache pci_stub vboxpci vboxnetadp vboxnetflt vboxdrv cfg80211 nls_iso8859_1 joydev snd_hda_codec_realtek snd_hda_codec_hdmi snd_hda_codec_generic intel_rapl iosf_mbi x86_pkg_temp_thermal intel_powerclamp coretemp kvm_intel hid_logitech_hidpp kvm crct10dif_pclmul crc32_pclmul ghash_clmulni_intel aesni_intel snd_soc_rt5640 aes_x86_64 snd_soc_rl6231 lrw snd_soc_core gf128mul snd_hda_intel glue_helper snd_hda_controller ablk_helper snd_compress cryptd snd_hda_codec snd_pcm_dmaengine snd_hwdep snd_pcm serio_raw snd_seq_midi snd_seq_midi_event snd_rawmidi snd_seq snd_seq_device snd_timer snd mei_me mei i915 shpchp lpc_ich drm_kms_helper drm 8250_fintek dw_dmac i2c_algo_bit i2c_hid soundcore dw_dmac_core i2c_designware_platform 8250_dw snd_soc_sst_acpi i2c_designware_core video spi_pxa2xx_platform tpm_infineon mac_hid acpi_pad sunrpc parport_pc ppdev lp parport autofs4 hid_logitech_dj usbhid hid e1000e psmouse ahci ptp libahci pps_core sdhci_acpi sdhci
  ApportVersion: 2.17-0ubuntu1
  Architecture: amd64
  CurrentDesktop: XFCE
  Date: Sat Apr  4 21:38:52 2015
  InstallationDate: Installed on 2015-02-05 (58 days ago)
  InstallationMedia: Xubuntu 14.04.1 LTS "Trusty Tahr" - Release amd64 (20140723)
  MachineType: Gigabyte Technology Co., Ltd. H97-D3H
  ProcKernelCmdLine: \vmlinuz-3.19.0-9-generic.efi.signed ro root=UUID=840a4068-987e-4392-8835-3a32930cd96b quiet splash  initrd=\initrd.img-3.19.0-9-generic
  SourcePackage: systemd
  UpgradeStatus: Upgraded to vivid on 2015-03-02 (33 days ago)
  dmi.bios.date: 06/26/2014
  dmi.bios.vendor: American Megatrends Inc.
  dmi.bios.version: F5
  dmi.board.asset.tag: To be filled by O.E.M.
  dmi.board.name: H97-D3H-CF
  dmi.board.vendor: Gigabyte Technology Co., Ltd.
  dmi.board.version: x.x
  dmi.chassis.asset.tag: To Be Filled By O.E.M.
  dmi.chassis.type: 3
  dmi.chassis.vendor: Gigabyte Technology Co., Ltd.
  dmi.chassis.version: To Be Filled By O.E.M.
  dmi.modalias: dmi:bvnAmericanMegatrendsInc.:bvrF5:bd06/26/2014:svnGigabyteTechnologyCo.,Ltd.:pnH97-D3H:pvrTobefilledbyO.E.M.:rvnGigabyteTechnologyCo.,Ltd.:rnH97-D3H-CF:rvrx.x:cvnGigabyteTechnologyCo.,Ltd.:ct3:cvrToBeFilledByO.E.M.:
  dmi.product.name: H97-D3H
  dmi.product.version: To be filled by O.E.M.
  dmi.sys.vendor: Gigabyte Technology Co., Ltd.

To manage notifications about this bug go to:
https://bugs.launchpad.net/systemd/+bug/1440395/+subscriptions