← Back to team overview

touch-packages team mailing list archive

[Bug 1465386] Re: Default values for WAIT_STATE are wrong in the upstart wait-for-state job

 

The attachment "wait-for-state.conf.patch" seems to be a patch.  If it
isn't, please remove the "patch" flag from the attachment, remove the
"patch" tag, and if you are a member of the ~ubuntu-reviewers,
unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by
~brian-murray, for any issues please contact him.]

** Tags added: patch

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to upstart in Ubuntu.
https://bugs.launchpad.net/bugs/1465386

Title:
  Default values for WAIT_STATE are wrong in the upstart wait-for-state
  job

Status in upstart package in Ubuntu:
  New

Bug description:
  In Ubuntu 14.04, the wait-for-state job uses the env vars
  WAIT_STATE="started" or WAIT_STATE="stopped". if the GOAL env var is
  set to 'start' or 'stop'.

  However, according to the upstart cookbook, the desired states for a
  already started/stopped job are 'start/running' and 'stop/waiting'.
  Maybe a misunderstood has occurred was the meaning of signals was job
  states (for example, after a job reaches the start/running state, it
  emits the started signal).

  The strange thing is that the waiting/running wait states were
  proposed at the first implementations of this job, and not the
  stopped/started states: https://lists.ubuntu.com/archives/upstart-
  devel/2011-February/001405.html.

  This  bug can make some developers to write upstart jobs that return
  errors (like the GlusterFS developers, that forgot the
  WAIT_STATE="running" condition).

  References:

  - http://upstart.ubuntu.com/cookbook/#job-states
  - http://upstart.ubuntu.com/cookbook/#events-not-states
  - https://bugs.launchpad.net/ubuntu/+source/glusterfs/+bug/1465382

  I'm attaching a patch too.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/upstart/+bug/1465386/+subscriptions


References