← Back to team overview

touch-packages team mailing list archive

[Bug 1473422] [NEW] Platform check in request.cpp should check for ubuntu* platform

 

Public bug reported:

In request.cpp around line 318, the code checks "if
(QGuiApplication::platformName() != "xcb" ||
qgetenv("SSOUI_USE_UBUNTU_WEB_VIEW") == QByteArray("1")) {"

however it should either also have "... && != "wayland"" or have "... ==
"UbuntuTouchPlatformName""

This makes the signon-ui package shipped by ubuntu unusable on non-xcb
platforms as it's build with "USE_UBUNTU_WEB_VIEW" and so it will always
create "UbuntuBrowserRequest" rather than "BrowserRequest" which is what
is wanted.

** Affects: signon-ui (Ubuntu)
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to signon-ui in Ubuntu.
https://bugs.launchpad.net/bugs/1473422

Title:
  Platform check in request.cpp should check for ubuntu* platform

Status in signon-ui package in Ubuntu:
  New

Bug description:
  In request.cpp around line 318, the code checks "if
  (QGuiApplication::platformName() != "xcb" ||
  qgetenv("SSOUI_USE_UBUNTU_WEB_VIEW") == QByteArray("1")) {"

  however it should either also have "... && != "wayland"" or have "...
  == "UbuntuTouchPlatformName""

  This makes the signon-ui package shipped by ubuntu unusable on non-xcb
  platforms as it's build with "USE_UBUNTU_WEB_VIEW" and so it will
  always create "UbuntuBrowserRequest" rather than "BrowserRequest"
  which is what is wanted.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/signon-ui/+bug/1473422/+subscriptions


Follow ups