touch-packages team mailing list archive

[Michi Henning <michi.henning@xxxxxxxxxxxxx>]

It does not look like this this bug was fixed. I'm still seeing multiple
requests for a single image.

Go to events page in the gallery app and tap on a photo. Displaying that
single photo sends multiple requests to the thumbnailer:

thumbnailer-service: [01:01:02.355] "thumbnail: /home/phablet/Videos/com.ubuntu.camera/video20150720_010015553.mp4 (0,0): 0.009003 sec (FULL-SIZE HIT)"
thumbnailer-service: [01:01:02.378] "thumbnail: /home/phablet/Videos/com.ubuntu.camera/video20150720_010015553.mp4 (1060,1060): 0.023805 sec (FULL-SIZE HIT)"
thumbnailer-service: [01:01:02.383] "thumbnail: /home/phablet/Videos/com.ubuntu.camera/video20150720_010015553.mp4 (1222,1060): 0.010407 sec (FULL-SIZE HIT)"
thumbnailer-service: [01:01:02.400] "thumbnail: /home/phablet/Videos/com.ubuntu.camera/video20150720_010015553.mp4 (1222,1222): 0.025453 sec (FULL-SIZE HIT)"
thumbnailer-service: [01:01:02.454] "thumbnail: /home/phablet/Videos/com.ubuntu.camera/video20150720_010004143.mp4 (1222,1222): 0.004059 sec (FULL-SIZE HIT)"

Note that I'm seeing this every time I tap on a *photo*. However, the
thumbnail requests are for one of the videos I took. It looks like the
gallery app is asking for thumbnails for *video* files every time I tap
on a *photo*.

Also, the request for (0,0) is problematic. It means "Give me the image
at full size" (bounded to a 1920 box). A full-size image is most
definitely *not* a thumbnail. The gallery app shouldn't be asking for
"thumbnails" at full size. All this does is waste disk space and make
the cache less effective. Instead, for the full-size image, the gallery
app should be reading the image file directly, I would think?

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to gallery-app in Ubuntu.
https://bugs.launchpad.net/bugs/1460993

Title:
  Multiple thumbnail requests for a single image

Status in Canonical System Image:
  Fix Released
Status in gallery-app:
  In Progress
Status in gallery-app package in Ubuntu:
  Fix Released

Bug description:
  I just took two short videos and four photos on the phone. When I look
  at the events page in the gallery app, I see thumbnails for the these
  just fine. I'm also tracing the requests that are made to the
  thumbnailer. When I tap on one of the photos, I see the following
  requests fired at the thumbnailer all at once (within one or two
  tenths of a second):

  Create thumbnail for "/home/phablet/Pictures/com.ubuntu.camera/image20150602_073643136.jpg" at size QSize(216, 216)
  Create thumbnail for "/home/phablet/Pictures/com.ubuntu.camera/image20150602_073643136.jpg" at size QSize(216, -1)
  Create thumbnail for "/home/phablet/Pictures/com.ubuntu.camera/image20150602_073643136.jpg" at size QSize(231, 0)
  Create thumbnail for "/home/phablet/Pictures/com.ubuntu.camera/image20150602_073643136.jpg" at size QSize(256, 0)
  Create thumbnail for "/home/phablet/Pictures/com.ubuntu.camera/image20150602_073643136.jpg" at size QSize(291, 0)
  Create thumbnail for "/home/phablet/Pictures/com.ubuntu.camera/image20150602_073643136.jpg" at size QSize(341, 0)
  Create thumbnail for "/home/phablet/Pictures/com.ubuntu.camera/image20150602_073643136.jpg" at size QSize(402, 0)
  Create thumbnail for "/home/phablet/Pictures/com.ubuntu.camera/image20150602_073643136.jpg" at size QSize(477, 0)
  Create thumbnail for "/home/phablet/Pictures/com.ubuntu.camera/image20150602_073643136.jpg" at size QSize(558, 0)
  Create thumbnail for "/home/phablet/Pictures/com.ubuntu.camera/image20150602_073643136.jpg" at size QSize(657, 0)
  Create thumbnail for "/home/phablet/Pictures/com.ubuntu.camera/image20150602_073643136.jpg" at size QSize(768, 0)
  Create thumbnail for "/home/phablet/Pictures/com.ubuntu.camera/image20150602_073643136.jpg" at size QSize(768, 1222)

  This is horribly wasteful because the app retrieves the same image a
  dozen times. But, worse, we will cache thumbnailer in twelve different
  sizes for that same single image because we are being asked for a
  different size each time.

  Also note that requests with width or height < 0 are interpreted to
  mean "as large as possible". The second request above consequently
  causes the image to be cached in its full size (unless it's larger
  than 1920, in which case we limit it to 1920x1920 bounding box).

  Something seems definitely wrong here. The multiple requests are
  wasteful, and the different sizes mean that the cache is far less
  effective than it could be.

To manage notifications about this bug go to:
https://bugs.launchpad.net/canonical-devices-system-image/+bug/1460993/+subscriptions