← Back to team overview

touch-packages team mailing list archive

[Bug 1478115] Re: using PathExistsGlob in apport-noui.path results in test failures

 

I've uploaded apport version 2.18-0ubuntu5 which removes the dependency
of apport-noui on whoopsie as a stop gap measure.

** Description changed:

  I've switched the apport-noui.path systemd file from:
  
  PathChanged=/var/crash
  
  to
  
  PathExistsGlob=/var/crash/*.crash
  
  I've done this because with PathChanged it seemed to me that the
  whoopsie-upload-all, called by apport-noui.service, would be called when
  any file (e.g. .upload, .uploaded) were created in /var/crash.
  Naturally, this seemed excessive to me and PathExistsGlob seems like a
  better fit.  Additionally, it is worth noting that the following from
  the systemd.path documentation:
  
  "If a path already exists (in case of PathExists= and PathExistsGlob=)
  or a directory already is not empty (in case of DirectoryNotEmpty=) at
  the time the path unit is activated, then the configured unit is
  immediately activated as well. Something similar does not apply to
  PathChanged= and PathModified=."
  
  Given that it appears with PathChanged the apport-noui service would
  never be run during boot up, again not what we want.
  
  However, making these changes seems to have caused some strange test
  failures with the apport's tests.
  
  https://jenkins.qa.ubuntu.com/job/wily-adt-apport/
+ 
+ runs 47 through 55

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to systemd in Ubuntu.
https://bugs.launchpad.net/bugs/1478115

Title:
  using PathExistsGlob in apport-noui.path results in test failures

Status in systemd package in Ubuntu:
  New

Bug description:
  I've switched the apport-noui.path systemd file from:

  PathChanged=/var/crash

  to

  PathExistsGlob=/var/crash/*.crash

  I've done this because with PathChanged it seemed to me that the
  whoopsie-upload-all, called by apport-noui.service, would be called
  when any file (e.g. .upload, .uploaded) were created in /var/crash.
  Naturally, this seemed excessive to me and PathExistsGlob seems like a
  better fit.  Additionally, it is worth noting that the following from
  the systemd.path documentation:

  "If a path already exists (in case of PathExists= and PathExistsGlob=)
  or a directory already is not empty (in case of DirectoryNotEmpty=) at
  the time the path unit is activated, then the configured unit is
  immediately activated as well. Something similar does not apply to
  PathChanged= and PathModified=."

  Given that it appears with PathChanged the apport-noui service would
  never be run during boot up, again not what we want.

  However, making these changes seems to have caused some strange test
  failures with the apport's tests.

  https://jenkins.qa.ubuntu.com/job/wily-adt-apport/

  runs 47 through 55

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1478115/+subscriptions


References