← Back to team overview

touch-packages team mailing list archive

[Bug 1450988] Re: [Infographic] Duplicate metrics for no calls made today

 

- Design comment -
  05/08/2015

It can't be fixed as a single bug. The desired resolution and specs will
be updated as soon as they are available.
https://canonical.leankit.com/Boards/View/109386535/113890502

** Description changed:

  I noticed that when tapping on the welcome screen, the metrics for "No
  calls made today"" were shown twice. That is:
  
  1. Tap on the circle until you see "No calls made today""
  2. Double tap again
  
  Actual:
-  - The same "No calls made today"" text is shown, but with a different diagram
+  - The same "No calls made today"" text is shown, but with a different diagram
  
  Expected:
  - "No time spent on calls today" (or similar) is shown
  
  I think it just needs a one-liner change on this code in
  indicator/metrics.cpp [1]. I would suggest "No time spent on calls
  today" on the second instance.
  
  This will also need a .pot file update to expose the new string to
  translators.
  
-         mMetrics[OutgoingCalls] = mMetricManager->add(MetricParameters(DIALER_OUTGOING_STATISTICS_ID).formatString(GettextMarkExtraction("<b>%1</b> calls made today"))
-                                                       .emptyDataString(GettextMarkExtraction("No calls made today")).textDomain(APP_ID).minimum(0.0));
-         mMetrics[CallDurations] = mMetricManager->add(MetricParameters(DIALER_CALL_DURATION_STATISTICS_ID).formatString(GettextMarkExtraction("Spent <b>%1</b> minutes in calls today"))
-                                                       .emptyDataString(GettextMarkExtraction("No calls made today")).textDomain(APP_ID).minimum(0.0));
+         mMetrics[OutgoingCalls] = mMetricManager->add(MetricParameters(DIALER_OUTGOING_STATISTICS_ID).formatString(GettextMarkExtraction("<b>%1</b> calls made today"))
+                                                       .emptyDataString(GettextMarkExtraction("No calls made today")).textDomain(APP_ID).minimum(0.0));
+         mMetrics[CallDurations] = mMetricManager->add(MetricParameters(DIALER_CALL_DURATION_STATISTICS_ID).formatString(GettextMarkExtraction("Spent <b>%1</b> minutes in calls today"))
+                                                       .emptyDataString(GettextMarkExtraction("No calls made today")).textDomain(APP_ID).minimum(0.0));
  
  [1] http://bazaar.launchpad.net/~phablet-team/telephony-
  service/trunk/view/head:/indicator/metrics.cpp#L48
+ 
+ 
+ 
+ - Design comment -
+   05/08/2015
+ 
+ It can't be fixed as a single bug. The desired resolution and specs will
+ be updated as soon as they are available.
+ https://canonical.leankit.com/Boards/View/109386535/113890502

** Changed in: ubuntu-ux
       Status: Triaged => Won't Fix

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to telephony-service in
Ubuntu.
https://bugs.launchpad.net/bugs/1450988

Title:
  [Infographic] Duplicate metrics for no calls made today

Status in Ubuntu UX:
  Won't Fix
Status in telephony-service package in Ubuntu:
  New

Bug description:
  I noticed that when tapping on the welcome screen, the metrics for "No
  calls made today"" were shown twice. That is:

  1. Tap on the circle until you see "No calls made today""
  2. Double tap again

  Actual:
   - The same "No calls made today"" text is shown, but with a different diagram

  Expected:
  - "No time spent on calls today" (or similar) is shown

  I think it just needs a one-liner change on this code in
  indicator/metrics.cpp [1]. I would suggest "No time spent on calls
  today" on the second instance.

  This will also need a .pot file update to expose the new string to
  translators.

          mMetrics[OutgoingCalls] = mMetricManager->add(MetricParameters(DIALER_OUTGOING_STATISTICS_ID).formatString(GettextMarkExtraction("<b>%1</b> calls made today"))
                                                        .emptyDataString(GettextMarkExtraction("No calls made today")).textDomain(APP_ID).minimum(0.0));
          mMetrics[CallDurations] = mMetricManager->add(MetricParameters(DIALER_CALL_DURATION_STATISTICS_ID).formatString(GettextMarkExtraction("Spent <b>%1</b> minutes in calls today"))
                                                        .emptyDataString(GettextMarkExtraction("No calls made today")).textDomain(APP_ID).minimum(0.0));

  [1] http://bazaar.launchpad.net/~phablet-team/telephony-
  service/trunk/view/head:/indicator/metrics.cpp#L48


  
  - Design comment -
    05/08/2015

  It can't be fixed as a single bug. The desired resolution and specs
  will be updated as soon as they are available.
  https://canonical.leankit.com/Boards/View/109386535/113890502

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-ux/+bug/1450988/+subscriptions


References