← Back to team overview

touch-packages team mailing list archive

[Bug 1485787] Re: package_hook does not include package version

 

Note that this isn't how apport is supposed to work: Calling any hook is
*not* sufficient for producing a report, you have to let the UI post-
process the report; that will call add_package_info() and thus the
complete package and version. If you run the test case, and click on
"show details", you will see package and version without this patch. I'd
therefore like to revert this change in wily.

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to apport in Ubuntu.
https://bugs.launchpad.net/bugs/1485787

Title:
  package_hook does not include package version

Status in apport package in Ubuntu:
  Incomplete
Status in apport source package in Trusty:
  Fix Committed
Status in apport source package in Vivid:
  Fix Committed

Bug description:
  All of these problem reports are missing a package version:

  https://errors.ubuntu.com/problem/abc807de9d9c87d965fea31c865192edb30b6738

  This is because package_hook in apport only writes the following:

  pr['Package'] = options.package

  We should include the package version in the problem report.

  Test Case
  ---------
  1) echo "You have failed this city." | /usr/share/apport/package_hook -p apport
  2) grep "^Package" /var/crash/apport.1000.crash

  With the current version of apport you'll only see the package name,
  with the version from -proposed you'll see the package version in
  addition to the name.

  Regression Potential
  --------------------
  Worst case scenario I screwed the patch up and we loose the package name too, but given that it works in wily and there is a test for it in test_hooks.py that seems unlikely.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/apport/+bug/1485787/+subscriptions


References