touch-packages team mailing list archive

[Martin Pitt <martin.pitt@xxxxxxxxxx>]

*** This bug is a duplicate of bug 1485787 ***
    https://bugs.launchpad.net/bugs/1485787

I looked at this more deeply now. Using only_new makes sense as we want
to write the report in "append" mode, to avoid having to unnecessarily
rewrite potentially large reports (core dumps, kernel crash dumps). So
indeed we should fix the hooks to just call add_package_info() instead
of the current dance.

** Summary changed:

- only_new option when writing reports stops some data from being written
+ hooks: don't add incomplete Package: information

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to apport in Ubuntu.
https://bugs.launchpad.net/bugs/1485773

Title:
  hooks: don't add incomplete Package: information

Status in apport package in Ubuntu:
  In Progress

Bug description:
  I was trying to figure out why package installation failures didn't
  always have package versions in them e.g.

  https://errors.ubuntu.com/problem/abc807de9d9c87d965fea31c865192edb30b6738
  https://errors.ubuntu.com/oops/7dcf4756-42b9-11e5-a0ab-fa163e78b027

  Digging into this I discovered that package_hook from apport writes a
  Package key but does not include the version of the package with that
  key.  Apparently, I fixed the same thing 18 months ago with the
  kernel_oops file.

  apport (2.13.2-0ubuntu4) trusty; urgency=medium

    * data/kernel_oops: include the package version in addition to the
  name

   -- Brian Murray <brian@xxxxxxxxxx>  Fri, 14 Feb 2014 14:09:39 -0800

  Investigating the matter further it, report.write() is called with
  new_only=True which means that even though the package version
  information has been collected (by add_package_info) we do not write
  it to the report. Naturally, this is rather confusing and means that
  fixes to data collection in apport may not appear in all reports e.g.
  if we change how origin information is calculated (which appears in
  the value for Package) we need to change package_hook and kernel_oops
  for the updated origin information.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/apport/+bug/1485773/+subscriptions