txamqp-user team mailing list archive

[Esteve Fernandez <esteve.fernandez@xxxxxxxxx>]

Hi,

sorry to chime in so late. I just got back from holidays, I'll have a
look at your patch as soon as I can.

Thanks a lot for your patience.

On Mon, Aug 30, 2010 at 2:26 PM, matteo brancaleoni
<mbrancaleoni@xxxxxxxxx> wrote:
> nevermind,
>
>> The patch is very trivial and "works for me":
>>
>> --- txamqp.orig/src/txamqp/protocol.py  2010-08-05 13:18:05.000000000 +0200
>> +++ txamqp/src/txamqp/protocol.py       2010-08-30 10:32:22.000000000 +0200
>> @@ -32,9 +32,11 @@
>>         self.closed = False
>>         self.reason = None
>>
>> +    @defer.inlineCallbacks
>>     def close(self, reason):
>>         if self.closed:
>>             return
>> +        yield self.channel_close()
>>         self.closed = True
>>         self.reason = reason
>>         self.incoming.close()
>>
>
>
> this patch introduces a memory leak, so another solution to properly
> close the channel
> must be found.
>
> regards,
> matteo.
>
> _______________________________________________
> Mailing list: https://launchpad.net/~txamqp-user
> Post to     : txamqp-user@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~txamqp-user
> More help   : https://help.launchpad.net/ListHelp
>