txaws-dev team mailing list archive
-
txaws-dev team
-
Mailing list archive
-
Message #00033
Re: [Merge] lp:~fwierzbicki/txaws/break-out-ec2-parser into lp:txaws
> Man, I can't tell you how badly I've wanted this... since about the second or
> third week Thomas and I were working on the ec2 client support!
>
> 1) Overall, looks awesome -- nice work, and thanks :-)
No problem! It will make my cloud deck work nicer :)
> 2) The Parser class seems to have a superfluous __init__; I'd just recommend
> removing it.
Fixed.
> 3) This is a nit... totally up to you, but now that the parse_* methods are in
> their own Parse class, I'd just remove the "parse_" from each method name.
> With them in there, it looks like C code ;-)
Fixed.
--
https://code.launchpad.net/~fwierzbicki/txaws/break-out-ec2-parser/+merge/58623
Your team txAWS Developers is requested to review the proposed merge of lp:~fwierzbicki/txaws/break-out-ec2-parser into lp:txaws.
References