← Back to team overview

ubiquity-slideshow team mailing list archive

Re: [Merge] lp:~ubuntu-mate-dev/ubiquity-slideshow-ubuntu/ubuntu-mate-update into lp:ubiquity-slideshow-ubuntu

 

Review: Needs Fixing

I fixed the changelog (please use dch -a next time you edit it, that way, you will get your name in), also fixed identation.

However, did you try to build the package? I can't get it building:
dh_install: oem-config-slideshow-ubuntu-mate missing files (build/oem-config-ubuntu-mate/*), aborting
/usr/share/cdbs/1/rules/debhelper.mk:213: recipe for target 'binary-install/oem-config-slideshow-ubuntu-mate' failed
make: *** [binary-install/oem-config-slideshow-ubuntu-mate] Error 2


Here is the patch for the fixed changelog:
=== modified file 'debian/changelog'
--- debian/changelog	2015-03-02 17:47:52 +0000
+++ debian/changelog	2015-03-06 14:02:55 +0000
@@ -1,8 +1,11 @@
 ubiquity-slideshow-ubuntu (93) UNRELEASED; urgency=medium
 
+  [ Pasi Lallinaho ]
   * Update the test script to work with the new Makefile.
+
+  [ Martin Wimpress ]
   * Update Ubuntu MATE slides and add OEM slideshow for
-  Ubuntu MATE.
+    Ubuntu MATE.
 
  -- Pasi Lallinaho <pasi@xxxxxxxxxxxxxxxxxx>  Thu, 15 Jan 2015 22:21:51 +0200
 


-- 
https://code.launchpad.net/~ubuntu-mate-dev/ubiquity-slideshow-ubuntu/ubuntu-mate-update/+merge/251487
Your team Ubiquity Slideshow is requested to review the proposed merge of lp:~ubuntu-mate-dev/ubiquity-slideshow-ubuntu/ubuntu-mate-update into lp:ubiquity-slideshow-ubuntu.