ubuntu-accomplishments-contributors team mailing list archive

[Gabriel <gepatino@xxxxxxxxx>]

2012/6/1 Janos Gyerik <info@xxxxxxxxxxx>

> Hi Gabriel,
>
> Nice, thanks a lot! Reviewed and merged your code into the trunk.
>
> > Should I move the trello card to Fix Commited? or someone else do that
> after
> > merging?
>
> Yup, that was the idea! You know what, "Fix Committed" was not a good
> name, so I renamed it to "Done and committed to a branch". And after
> somebody reviews and merges into the mainline branch, let's drag to
> the third list, named "Done and merged into trunk". Makes more sense?
>
> I didn't get what you meant in your comment about unit tests. The unit
> tests were not broken, I double checked now. After merging your code
> they are still not broken, working just fine. Are they not in your
> env? Send me your stack trace!
>
> Cheers,
> Janos
>
> --
> Janos Gyerik
> http://titan2x.com/
>



Tests are passing if I check common and gallery (as stated in the README
file).

I was being a bit lazy and running ./manage.py test and got some fails from
django.contrib.messages and django_openid_auth.

I'll add some tests to the code changes I made.


-- 
Gabriel E. Patiño

http://about.me/gepatino