ubuntu-apps-bugs team mailing list archive

[Olivier Tilloy <olivier.tilloy@xxxxxxxxxxxxx>]

** Changed in: notes-app
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Apps bug tracking, which is subscribed to notes-app in Ubuntu.
https://bugs.launchpad.net/bugs/1218497

Title:
  Using deprecated properties of Toolbar and MainView

Status in Notes App:
  Fix Released
Status in “notes-app” package in Ubuntu:
  Fix Released

Bug description:
  This code is in NotesApp.qml:

          tools: ToolbarItems {
              ToolbarButton {
                  action: Action {
                      text: i18n.tr("Add")
                      iconSource: Qt.resolvedUrl("Components/graphics/add.png")
                      onTriggered: {
                          notesMainWindow.toolbar.active = false
                          notesMainWindow.createNewNote()
                      }
                  }

  Toolbar.active has been deprecated for some time and is about to be removed.
  MainView.toolbar does not exist. So the add button on the toolbar does not work (at least not with my UITK branch where I removed the deprecated properties).

  Please remove those properties. Instead of using toolbar.active, use
  the 'opened' property of the ToolbarItems. These changes are needed
  for the toolbar code cleanup https://code.launchpad.net/~tpeeters
  /ubuntu-ui-toolkit/toolbar-clean/+merge/181741 that is required for an
  MR that will follow that improves automatic reveal/hide of the
  toolbar.

To manage notifications about this bug go to:
https://bugs.launchpad.net/notes-app/+bug/1218497/+subscriptions