ubuntu-apps-bugs team mailing list archive

[Michael Terry <michael.terry@xxxxxxxxxxxxx>]

** Also affects: webbrowser-app (Ubuntu)
   Importance: Undecided
       Status: New

** Also affects: trust-store (Ubuntu)
   Importance: Undecided
       Status: New

-- 
You received this bug notification because you are a member of Ubuntu
Apps bug tracking, which is subscribed to webbrowser-app in Ubuntu.
https://bugs.launchpad.net/bugs/1581047

Title:
  UbuntuColors considered harmful

Status in trust-store package in Ubuntu:
  New
Status in ubuntu-system-settings package in Ubuntu:
  New
Status in ubuntu-system-settings-online-accounts package in Ubuntu:
  Confirmed
Status in unity8 package in Ubuntu:
  New
Status in webbrowser-app package in Ubuntu:
  New

Bug description:
  After the latest theme changes (that introduced blue and green to our
  palette), there are incorrect colors in ubuntu-system-settings (and
  elsewhere).

  Partly because of hardcoded colors via UbuntuColors.  Ideally,
  semantic color names from the palette would be used instead.
  "theme.palette.normal.positive" instead of "UbuntuColors.green" for
  example.

  A simple grep should give lots of locations that could be corrected.

  In addition, it seems that UbuntuColors.orange is used in several
  places that aren't focus related.  Like for buttons.  Those might want
  to switch to green via theme.palette.normal.positive.

  https://developer.ubuntu.com/api/apps/qml/sdk-15.04.4/Ubuntu.Components.Themes.PaletteValues/

  And if you're curious what the semantic colors actually resolve to,
  you can see the current mapping between UbuntuColors and the theme by
  looking at /usr/lib/x86_64-linux-
  gnu/qt5/qml/Ubuntu/Components/Themes/Ambiance/1.3/AmbianceNormal.qml
  (or wherever it lives on your system).

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/trust-store/+bug/1581047/+subscriptions