← Back to team overview

ubuntu-bots team mailing list archive

[Merge] lp:~lderan/ubuntu-bots/meeetingology-output into lp:~ubuntu-bots/ubuntu-bots/meetingology

 

Thomas Molloy has proposed merging lp:~lderan/ubuntu-bots/meeetingology-output into lp:~ubuntu-bots/ubuntu-bots/meetingology.

Requested reviews:
  Ubuntu IRC Bots (ubuntu-bots)

For more details, see:
https://code.launchpad.net/~lderan/ubuntu-bots/meeetingology-output/+merge/205383

fix for the vote output
-- 
https://code.launchpad.net/~lderan/ubuntu-bots/meeetingology-output/+merge/205383
Your team Ubuntu IRC Bots is requested to review the proposed merge of lp:~lderan/ubuntu-bots/meeetingology-output into lp:~ubuntu-bots/ubuntu-bots/meetingology.
=== modified file 'writers.py'
--- writers.py	2013-11-19 23:51:36 +0000
+++ writers.py	2014-02-07 15:21:23 +0000
@@ -1215,7 +1215,7 @@
         Votes = [ ]
         Votes.append(self.heading('Vote results'))
         # reversed to show the oldest first
-        for m in reversed(M.votes):
+        for m in M.votes:
             # differentiate denied votes somehow, strikethrough perhaps?
             Votes.append(" * [[%(fullLogsFullURL)s#"+str(M.votes[m][3])+" "+m+"]]")
             motion = "Deadlock"
@@ -1228,7 +1228,10 @@
             if len(M.publicVoters[m]) > 0:
                 publicVoters = ', '.join(set(M.publicVoters[m]))
                 Votes.append("   *  Voters " + publicVoters)
-        Votes = "\n".join(Votes) 
+        if len(Votes) > 0:
+            Votes = "\n".join(reversed(Votes)) # reversed to show the oldest first
+        else:
+            Votes = "\n"
         return Votes
 
     def actionItems(self):