ubuntu-bugcontrol team mailing list archive

[Norbert <1214352@xxxxxxxxxxxxxxxxxx>]

** Summary changed:

- GUINT32/64_SWAP_LE_BE macros do not enclose val argument in parentheses
+ [SRU] GUINT32/64_SWAP_LE_BE macros do not enclose val argument in parentheses

** Description changed:

+ [Impact] 
+  * This bug affects Glib-dependent packages, one of them is modern version of LibreOffice 4.x from PPA (https://launchpad.net/~libreoffice/+archive/ubuntu/ppa).
+ * LibreOffice is very important software. Modern versions are more functional. Without them Ubuntu is nothing, it is a toy.
+ 
+ [Test Case]
+  1. Place OpenDocument file (for example 'test.odt') on SMB/CIFS server (Samba on GNU/Linux, or from Windows). Make this share available for read-write.
+  2a.1. Open Nautilus, navigate it to 'smb://server_name/share_name/', wait the share to be mounted with GVFS.
+  2a.2. Double click on 'test.odt'
+  3. Get error message from LibreOffice:
+      "The file 'test.odt' is corrupt and therefore cannot be opened.      
+      LibreOffice can try to repair the file.
+      
+         The corruption could be the result of document manipulation or of 
+      structural document damage due to data transmission.
+      We recommend that you do not trust the content of the repaired document.
+      Execution of macros is disabled for this document.
+ 
+         Should LibreOffice repair the file?
+ 
+         Yes     No"
+  4a. If I click 'Yes', the file is opened, but the title of the document 
+           is "Untitled 1 (repaired document)", not original name.
+  4b. If I click 'No', the dialog 'LibreOffice 4.4' is opened with text:
+           The file 'test.odt' could not be repaired and therefore cannot be opened.
+         OK"
+ 
+         I click 'OK' here, the next window "LibreOffice 4.4.1.2" is opened with text:
+         "General Error.
+         General input/output error.
+ 
+         OK"
+ 
+         If I click OK here - no files are opened.
+ 
+ While step 3 gvfsd-smb process eats CPU then terminates with error. This
+ error is caused by bug in Glib (wrong type conversion in macros).
+ 
+ [Regression Potential]
+ 
+  * This functionality is essential. Please fix this bug.
+ I (and you) can't tell Windows users, that they should not open office files from network shares in GNU/Linux.
+ 
+  * The patch has two lines
+ (https://git.gnome.org/browse/glib/commit/?id=255c65f83c1515a7e3fc4609b36e72acc08a79e4)
+ and well-tested at upstream.
+ 
+  * This bug may cause potential loss of data.
+ 
+ [Other Info]
+  
+  * Corresponding links to LibO bugs are:
+    https://bugs.freedesktop.org/show_bug.cgi?id=67527
+    https://bugs.documentfoundation.org/show_bug.cgi?id=72337
+ 
+ 
+ [Original description]
  On 12.04 LTS precise GUINT32/64_SWAP_LE_BE macros do not enclose val argument in parentheses, causing trouble down the stack in gvfs and LibreOffice (and possibly in lots of obscure bugs elsewhere).
  There is a patch available, but as this touches the header, it needs a full recompile of rdepends.
  see: https://lists.fedoraproject.org/pipermail/devel/2013-March/180302.html ff. for details

** Description changed:

- [Impact] 
-  * This bug affects Glib-dependent packages, one of them is modern version of LibreOffice 4.x from PPA (https://launchpad.net/~libreoffice/+archive/ubuntu/ppa).
+ [Impact]
+  * This bug affects Glib-dependent packages, one of them is modern version of LibreOffice 4.x from PPA (https://launchpad.net/~libreoffice/+archive/ubuntu/ppa).
  * LibreOffice is very important software. Modern versions are more functional. Without them Ubuntu is nothing, it is a toy.
  
  [Test Case]
-  1. Place OpenDocument file (for example 'test.odt') on SMB/CIFS server (Samba on GNU/Linux, or from Windows). Make this share available for read-write.
-  2a.1. Open Nautilus, navigate it to 'smb://server_name/share_name/', wait the share to be mounted with GVFS.
-  2a.2. Double click on 'test.odt'
-  3. Get error message from LibreOffice:
-      "The file 'test.odt' is corrupt and therefore cannot be opened.      
-      LibreOffice can try to repair the file.
-      
-         The corruption could be the result of document manipulation or of 
-      structural document damage due to data transmission.
-      We recommend that you do not trust the content of the repaired document.
-      Execution of macros is disabled for this document.
+  1. Place OpenDocument file (for example 'test.odt') on SMB/CIFS server (Samba on GNU/Linux, or from Windows). Make this share available for read-write.
+  2a.1. Open Nautilus, navigate it to 'smb://server_name/share_name/', wait the share to be mounted with GVFS.
+  2a.2. Double click on 'test.odt'
+  2b. Launch terminal and send 'libreoffice smb://server_name/share_name/test.odt' command.
+  3. Get error message from LibreOffice:
+      "The file 'test.odt' is corrupt and therefore cannot be opened.
+      LibreOffice can try to repair the file.
  
-         Should LibreOffice repair the file?
+         The corruption could be the result of document manipulation or of
+      structural document damage due to data transmission.
+      We recommend that you do not trust the content of the repaired document.
+      Execution of macros is disabled for this document.
  
-         Yes     No"
-  4a. If I click 'Yes', the file is opened, but the title of the document 
-           is "Untitled 1 (repaired document)", not original name.
-  4b. If I click 'No', the dialog 'LibreOffice 4.4' is opened with text:
-           The file 'test.odt' could not be repaired and therefore cannot be opened.
-         OK"
+         Should LibreOffice repair the file?
  
-         I click 'OK' here, the next window "LibreOffice 4.4.1.2" is opened with text:
-         "General Error.
-         General input/output error.
+         Yes     No"
+  4a. If I click 'Yes', the file is opened, but the title of the document
+           is "Untitled 1 (repaired document)", not original name.
+  4b. If I click 'No', the dialog 'LibreOffice 4.4' is opened with text:
+           The file 'test.odt' could not be repaired and therefore cannot be opened.
+         OK"
  
-         OK"
+         I click 'OK' here, the next window "LibreOffice 4.4.1.2" is opened with text:
+         "General Error.
+         General input/output error.
  
-         If I click OK here - no files are opened.
+         OK"
+ 
+         If I click OK here - no files are opened.
  
  While step 3 gvfsd-smb process eats CPU then terminates with error. This
  error is caused by bug in Glib (wrong type conversion in macros).
  
  [Regression Potential]
  
-  * This functionality is essential. Please fix this bug.
+  * This functionality is essential. Please fix this bug.
  I (and you) can't tell Windows users, that they should not open office files from network shares in GNU/Linux.
  
-  * The patch has two lines
+  * The patch has two lines
  (https://git.gnome.org/browse/glib/commit/?id=255c65f83c1515a7e3fc4609b36e72acc08a79e4)
  and well-tested at upstream.
  
-  * This bug may cause potential loss of data.
+  * This bug may cause potential loss of data.
  
  [Other Info]
-  
-  * Corresponding links to LibO bugs are:
-    https://bugs.freedesktop.org/show_bug.cgi?id=67527
-    https://bugs.documentfoundation.org/show_bug.cgi?id=72337
  
+  * Corresponding links to LibO bugs are:
+    https://bugs.freedesktop.org/show_bug.cgi?id=67527
+    https://bugs.documentfoundation.org/show_bug.cgi?id=72337
  
  [Original description]
  On 12.04 LTS precise GUINT32/64_SWAP_LE_BE macros do not enclose val argument in parentheses, causing trouble down the stack in gvfs and LibreOffice (and possibly in lots of obscure bugs elsewhere).
  There is a patch available, but as this touches the header, it needs a full recompile of rdepends.
  see: https://lists.fedoraproject.org/pipermail/devel/2013-March/180302.html ff. for details

** Tags added: ppa

** Also affects: libreoffice (Ubuntu)
   Importance: Undecided
       Status: New

-- 
You received this bug notification because you are a member of Ubuntu
Bug Control, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1214352

Title:
  [SRU] GUINT32/64_SWAP_LE_BE macros do not enclose val argument in
  parentheses

To manage notifications about this bug go to:
https://bugs.launchpad.net/df-libreoffice/+bug/1214352/+subscriptions