← Back to team overview

ubuntu-bugcontrol team mailing list archive

Re: [Merge] ~emitorino/ubuntu-qa-tools:support_updates_ppas into ubuntu-qa-tools:master

 

On Wed, Dec 13, 2023 at 09:23:49PM -0000, Emilia Torino wrote:
> 
> 
> Diff comments:
> 
> > diff --git a/security-tools/unembargo b/security-tools/unembargo
> > index a78c826..936d180 100755
> > --- a/security-tools/unembargo
> > +++ b/security-tools/unembargo
> > @@ -106,6 +117,14 @@ if opt.esm or opt.esm_apps or opt.esm_infra:
> >          opt.destination = ESM_INFRA_PRODUCTION_PPA
> >          opt.ppa = ESM_INFRA_STAGING_PPA
> >          opt.pocket = RELEASE_POCKET
> > +    elif opt.esm_infra_updates:
> > +        opt.destination = ESM_INFRA_UPDATES_PRODUCTION_PPA
> > +        opt.ppa = ESM_INFRA_STAGING_PPA
> > +        opt.pocket = RELEASE_POCKET
> > +    elif opt.esm_app_updates:
> > +        opt.destination = ESM_APPS_UPDATES_PRODUCTION_PPA
> > +        opt.ppa = ESM_INFRA_STAGING_PPA
> 
> I already run this and did:
> for esm-infra: ./unembargo --esm-infra -r noble $SRCPKG
> for esm-apps: ./unembargo --ppa=ubuntu-esm/esm-infra-security-staging --destination=ubuntu-esm/esm-apps-security --pocket=Release -r noble $SRCPKG 
> for esm-infra-updates: ./unembargo --esm-infra-updates -r noble $SRCPKG
> for esm-apps-updates: ./unembargo --esm-infra-updates -r noble $SRCPKG
> 
> Originally considered adding a esm-apps-from-infra option, but did not sound very clean to me so decided we can manually set the options... Thinking about it now again, maybe we should as otherwise we are leaving this single case (copying to esm-apps from esm-infra) unsupported by a single opt.

Given that *this* specific operation is a once-every-two-years
occurrence, I think it is okay to have to manually specify e.g. the
origin ppa and document that in the release cycle tasks. If we add
shortcut operations, we should add them for operations we expect to
be more commonly used (e.g. binary copying from a staging ppa to the
corresponding publication ppa).

Thanks for working through this process!

-- 
Steve Beattie
<sbeattie@xxxxxxxxxx>

https://code.launchpad.net/~emitorino/ubuntu-qa-tools/+git/ubuntu-qa-tools/+merge/457475
Your team Ubuntu Bug Control is subscribed to branch ubuntu-qa-tools:master.



References