ubuntu-bugcontrol team mailing list archive

Thread
Date

Re: [Merge] ~jslarraz/ubuntu-qa-tools:create-ssh-key into ubuntu-qa-tools:master

To: mp+460669@xxxxxxxxxxxxxxxxxx
From: Marc Deslauriers <mp+460669@xxxxxxxxxxxxxxxxxx>
Date: Fri, 16 Feb 2024 14:08:31 -0000
In-reply-to: <170807510107.3824582.16229759567601439856.launchpad@juju-98d295-prod-launchpad-17>
Reply-to: mp+460669@xxxxxxxxxxxxxxxxxx
Sender: noreply@xxxxxxxxxxxxx

Review: Needs Fixing

Prompt looks good!

I would switch makedirs() to mkdir(), we shouldn't be creating the user home directory, something clearly went wrong if we need to do that.

Please set permissions to 0o700 not 0o755, and use the mode parameter of mkdir() instead of doing a separate chmod.

Thanks!
-- 
https://code.launchpad.net/~jslarraz/ubuntu-qa-tools/+git/ubuntu-qa-tools/+merge/460669
Your team Ubuntu Bug Control is subscribed to branch ubuntu-qa-tools:master.

References

[Merge] ~jslarraz/ubuntu-qa-tools:create-ssh-key into ubuntu-qa-tools:master
From: Jorge Sancho Larraz, 2024-02-16