ubuntu-bugcontrol team mailing list archive

[Seth Arnold <mp+465509@xxxxxxxxxxxxxxxxxx>]

I like the idea but I've got some concerns about small pieces of it. :)

Thanks

Diff comments:

> diff --git a/vm-tools/vm-qrt b/vm-tools/vm-qrt
> index b2593d4..a5d5151 100755
> --- a/vm-tools/vm-qrt
> +++ b/vm-tools/vm-qrt
> @@ -139,6 +143,20 @@ $ sudo ./`basename $test_script` -v # script should run as root
>  EOM
>  }
>  
> +execute_test(){
> +    echo "== Executing test =="
> +    script_name="$1"
> +    if [ "$s" = "test-browser.py" ]; then
> +        s="testlib_browser.py"
> +    fi
> +    args="-c -p $prefix"
> +    topdir=`echo "$test_directory/$test_tarball" | sed 's/.tar.gz$//'`
> +    echo "Running:"
> +    echo "$ uvt cmd --user=$(whoami) $args \"cd '$topdir'; ./$s\""
> +    echo ""
> +    uvt cmd --user=$(whoami) $args "cd '$topdir'; ./$s"

I haven't actually used QRT in ages but I'm a little surprised about this --user=$(whoami) part, for a few reasons:

- the default really should "just work" for us most of the time. If we have to specify this everywhere uvt cmd is being used then we should address that reason. Maybe we need to standardize on using user ubuntu in our VMs and adjust our ssh configs to match? Maybe we need to standardize on using our logins in our VMs and adjust everything else to match? I'm not sure. But hard-coding this here feels likely to break "the other half" of the team for their current workflows.

- Some of our tests have to run as root, and are marked as # QRT-Privilege: root -- in order to run these, should the uvt cmd be run as root via -r rather than the $(whoami) user and then either failing or doing a sudo within that VM?

> +}
> +
>  #
>  # start main script
>  #


-- 
https://code.launchpad.net/~federicoquattrin/ubuntu-qa-tools/+git/ubuntu-qa-tools/+merge/465509
Your team Ubuntu Bug Control is requested to review the proposed merge of ~federicoquattrin/ubuntu-qa-tools:make_vm-qrt_execute_tests into ubuntu-qa-tools:master.