← Back to team overview

ubuntu-bugcontrol team mailing list archive

Re: [Merge] ~octagalland/ubuntu-qa-tools:unembargo_different_distros into ubuntu-qa-tools:master

 

Review: Approve

LGTM then, thanks!

Diff comments:

> diff --git a/security-tools/unembargo b/security-tools/unembargo
> index a78c826..ec2bdd4 100755
> --- a/security-tools/unembargo
> +++ b/security-tools/unembargo
> @@ -154,10 +158,12 @@ lp_version = "devel"
>  
>  lp = lpl_common.connect(version=lp_version)
>  ubuntu = lp.distributions['ubuntu']

AH, sorry, thanks for the clarification. This is ok for me to merge it then. Thanks!

> +src_distro = lp.distributions[opt.source_distribution]
> +dst_distro = lp.distributions[opt.destination_distribution]
>  
> -dest_archive, dest_group, dest_ppa = lpl_common.get_archive(opt.destination, lp, verbose=True, distribution=ubuntu)
> +dest_archive, dest_group, dest_ppa = lpl_common.get_archive(opt.destination, lp, verbose=True, distribution=dst_distro)
>  
> -origin_archive, origin_group, origin_ppa = lpl_common.get_archive(opt.ppa, lp, verbose=True, distribution=ubuntu)
> +origin_archive, origin_group, origin_ppa = lpl_common.get_archive(opt.ppa, lp, verbose=True, distribution=src_distro)
>  
>  series = dict()
>  if opt.release:


-- 
https://code.launchpad.net/~octagalland/ubuntu-qa-tools/+git/ubuntu-qa-tools/+merge/476433
Your team Ubuntu Bug Control is subscribed to branch ubuntu-qa-tools:master.



References