← Back to team overview

ubuntu-java team mailing list archive

[Bug 242720] Re: [New Upstream Release] Electric has released 8.06

 

>From a quick look (haven't actually built it):

- The repacked orig.tar.gz contains binary .class files. Please make get-orig-source remove them.
- Consider using java-wrappers instead of a custom launcher.
- Instead of "TODO" (which should be "TODO.Debian" anyway), why won't you actually add the icon?
- The files *.debhelper are autogenerated, are you sure they are needed?
- Consider using dh_install. This way, you can get rid of debian/dirs. If you're going to keep the custom wrapper, you can avoid the need for renaming by moving it to something like debian/wrappers/electric.
- debian/electric.desktop does not pass desktop-file-validate
- It's pointless to include ChangeLog.txt in docs, since it's installed with dh_installchangelogs (and if it isn't, use DEB_INSTALL_CHANGELOGS_ALL = ChangeLog.txt)


** Changed in: electric (Ubuntu)
     Assignee: Matvey Kozhev (sikon) => Onkar Shinde (onkarshinde)
       Status: In Progress => Incomplete

-- 
[New Upstream Release] Electric has released 8.06
https://bugs.launchpad.net/bugs/242720
You received this bug notification because you are a member of Java
Packaging, which is a direct subscriber.