ubuntu-packaging-guide-team team mailing list archive

[Iain Lane <iain@xxxxxxxxxxxxxxxxxxx>]

Review: Needs Fixing
(I re-merged your branch with trunk before looking)

Cheers for this! Looks very nice :-)

Comments:

  - I see "¶" at the end of headings that probably shouldn't be there.
  - "Index" in the main orange bar seems to go nowhere and the other index link leads to a page with only one entry. Do we plan on fleshing this out?
  - Looking at http://www.ubuntu.com/ubuntu, if that's what we're trying to be consistent with, the links at the top above the orange bar should be /in/ it. (Also there's no Ubuntu logo/text on the right hand side)
  - What's the login link for?
  - Is it possible to indent the code blocks a bit and/or give them a slightly shaded background?
  - Code blocks should probably have a fixed width font. For example, indentation matters when writing debian/changelog entries, and this should be clear on the page. See debian-dir-overview for examples of this.

Cheers!
Iain
-- 
https://code.launchpad.net/~fougner/ubuntu-packaging-guide/retheming/+merge/67513
Your team Ubuntu Packaging Guide Team is subscribed to branch lp:ubuntu-packaging-guide.