ubuntu-packaging-guide-team team mailing list archive

[Andrew Starr-Bochicchio <a.starr.b@xxxxxxxxx>]

Andrew Starr-Bochicchio has proposed merging lp:~andrewsomething/ubuntu-packaging-guide/get-orig-source into lp:ubuntu-packaging-guide.

Requested reviews:
  Ubuntu Packaging Guide Team (ubuntu-packaging-guide-team)

For more details, see:
https://code.launchpad.net/~andrewsomething/ubuntu-packaging-guide/get-orig-source/+merge/111700

On Fri, Jun 22, 2012 at 7:15 PM, Jamie Strandboge <jamie@xxxxxxxxxxxxx> wrote:
> On Fri, 2012-06-15 at 18:38 -0400, Andrew Starr-Bochicchio wrote:
>> On Fri, Jun 15, 2012 at 5:21 PM, Jamie Strandboge <jamie@xxxxxxxxxxxxx> wrote:
>> > I'm sorry to inform you that ubuntu-packaging-guide is being rejected
>> > for the following reason:
>> >  * the package does not provide a watch file. While this is the
>> > preferred method, if this is not possible, please consider adding a
>> > comments only watch file, a README.source file with clear instructions
>> > on how the source tarball was generated or use get-orig-source in
>> > debian/rules. This is required to verify the integrity of the source
>> > package.
>>
>> Alright, I'll add a dummy watch file or a README.source, but this
>> seems like strange grounds for rejection of a native package.
>
> Native or not, people need to be able to verify the integrity of a
> source package from some upstream source. While README.source or
> get-orig-source is probably better for a native package, it is important
> to document somewhere.
-- 
https://code.launchpad.net/~andrewsomething/ubuntu-packaging-guide/get-orig-source/+merge/111700
Your team Ubuntu Packaging Guide Team is requested to review the proposed merge of lp:~andrewsomething/ubuntu-packaging-guide/get-orig-source into lp:ubuntu-packaging-guide.

=== modified file 'debian/changelog'
--- debian/changelog	2012-06-20 10:01:45 +0000
+++ debian/changelog	2012-06-23 00:45:23 +0000
@@ -12,6 +12,7 @@
     leftover from the build process.
   * Install the html/_sources dir. They are linked to on the web site.
   * Adjust paths for new install locations
+  * debian/rules: Add a get-orig-source target.
 
   [ Andrew Starr-Bochicchio + Daniel Holbach ]
   * provide a means to ship per-language per-flavour packages, if a certain

=== modified file 'debian/rules'
--- debian/rules	2012-06-13 16:31:47 +0000
+++ debian/rules	2012-06-23 00:45:23 +0000
@@ -1,4 +1,7 @@
 #!/usr/bin/make -f
+
+VERSION:= $(shell dpkg-parsechangelog | sed -rne 's,^Version: ([^-]+).*,\1,p')
+
 %:
 	dh $@ --builddirectory=_build
 
@@ -43,3 +46,7 @@
 
 override_dh_install:
 	dh_install --list-missing
+
+get-orig-source:
+	bzr export -r tag:$(VERSION) --root=ubuntu-packaging-guide-$(VERSION).orig \
+		ubuntu-packaging-guide_$(VERSION).tar.gz lp:ubuntu-packaging-guide