ubuntu-packaging-guide-team team mailing list archive

[Dmitry Shachnev <mp+423560@xxxxxxxxxxxxxxxxxx>]

Thank you for your merge proposal. A couple of comments.

Diff comments:

> === modified file 'ubuntu-packaging-guide/packaging-new-software.rst'
> --- ubuntu-packaging-guide/packaging-new-software.rst	2018-01-04 09:48:28 +0000
> +++ ubuntu-packaging-guide/packaging-new-software.rst	2022-05-27 17:09:18 +0000
> @@ -33,7 +33,8 @@
>  to prepare for compilation.
>  
>  This will check for the required build dependencies. As ``hello`` is a simple
> -example, ``build-essential`` should provide everything we need. For more
> +example, ``build-essential`` should provide everything we need (and, in more
> +recent Ubuntu releases, e.g., 20.04, the ``texinfo`` package also).  For more

You can safely assume that the contributor is running at least 20.04. We don't need to support development on older releases.

>  complex programs, the command will fail if you do not have the needed libraries
>  and development files. Install the needed packages and repeat until the command
>  runs successfully.::
> @@ -113,7 +123,8 @@
>  All of these file are explained in more detail in the :doc:`overview of the
>  debian directory<./debian-dir-overview>` article.
>  
> -Finally commit the code to your packaging branch::
> +Finally commit the code to your packaging branch (make sure to ``bzr add``
> +any files that changed; for example, ``debian/source/format``)::

Unlike git, in bzr you don't need to ``bzr add`` changed files. You only need to add new files which were not tracked previously.

>  
>      $ bzr add debian/source/format
>      $ bzr commit -m "Initial commit of Debian packaging."


-- 
https://code.launchpad.net/~mfo/ubuntu-packaging-guide/ubuntu-packaging-guide/+merge/423560
Your team Ubuntu Packaging Guide Team is requested to review the proposed merge of lp:~mfo/ubuntu-packaging-guide/ubuntu-packaging-guide into lp:ubuntu-packaging-guide.