← Back to team overview

ubuntu-phone team mailing list archive

Re: [PATCH] Do not try starting vold, netd, keystore and app_process from init.rc

 

Revised patch that removes those lines and bootanim too.

cheers
Jani

On Thu, Apr 18, 2013 at 5:24 PM, Sergio Schvezov
<sergio.schvezov@xxxxxxxxxxxxx> wrote:
> On Thu, Apr 18, 2013 at 05:02:55PM +0300, Jani Monoses wrote:
>> On Thu, Apr 18, 2013 at 4:59 PM, Ricardo Salveti de Araujo
>> <ricardo.salveti@xxxxxxxxxxxxx> wrote:
>> > On 04/18/2013 10:55 AM, Sergio Schvezov wrote:
>> >>
>> >> On Thu, Apr 18, 2013 at 11:59:23AM +0300, Jani Monoses wrote:
>> >>>
>> >>> I attach a patch that disables starting these in init.rc to avoid such
>> >>> error messages.
>> >>
>> >>
>> >> Any reason to comment instead of just remove? I would prefer removal
>> >> myself.
>> >
>> >
>> > +1 to remove.
>> >
>>
>> I just followed what was done for bootanim, which is commented out in
>> the same file, and for keeping
>> the context handy in case there's a merge with upstream.
>> I am fine with removing.
>
> That's a leftover from when we didn't have a repo and just some mega patches.
> Feel free to remove that one too if you like.
>
>> > I'm just not so sure about vold, as I remember people saying that it's
>> > needed for a few devices, need to investigate further.
>>
>> I just saw it is not built for mako, did not know we build different
>> Android bits depending on target.
>
> Well if someone needs it, they can add it to their devices init.rc, right?
>
>
> --
> Mailing list: https://launchpad.net/~ubuntu-phone
> Post to     : ubuntu-phone@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~ubuntu-phone
> More help   : https://help.launchpad.net/ListHelp

Attachment: 0001-Do-not-try-starting-inexistent-services-in-init.rc.patch
Description: Binary data


Follow ups

References